Add manual mode to noise reduction + add noise reduction threshold #1007
Conversation
|
The following links are available:
build (macOS-latest, full) build (windows-latest, full) build (ubuntu-18.04, android) |
|
This is ready for review now. |
|
The following links are available:
build (macOS-latest, full) build (windows-latest, full) build (ubuntu-18.04, android) |
|
I seems to work, but I could not find anyone online on master so I did not actually talk to anyone 😄 |
I actually talk to myself, no joke. I'd just listen on my other client to see at what points I'd hear me. :) |
|
UI suggestion: Change "Noise Reduction: Manual/Automatic" to "Manual Noise Reduction". |
|
Currently it's a switch that controls the value of "noiseValueAutomatic" , but I could reverse it and rename it probably, yeah. |
"Noise Reduction: Manual/Automatic" -> "Manual Noise Reduction"
Co-authored-by: David Rowe <[email protected]>
Co-authored-by: David Rowe <[email protected]>
|
The following links are available: build (ubuntu-18.04, full)
build (windows-latest, full) build (ubuntu-18.04, android) |
ctrlaltdavid
added
needs testing (QA)
|
Threshold seems to do what it's supposed to do.. HOWEVER... the "test your mic" audio feed seems to be pre-noise reduction so this is probably not the most ideal place in the signal flow. Ideally the feed played while you "test your mic| would be after noise reduction. |
|
The following links are available: build (ubuntu-18.04, full)
build (windows-latest, full) build (ubuntu-18.04, android) |
|
The following links are available: build (ubuntu-18.04, full)
build (windows-latest, full) build (ubuntu-18.04, android) |
|
Mic listen now working post-noise reduction. Seems to be working as intended. |
digisomni
added
QA Approved
Fix default value for "NoiseReductionAutomatic" to true.
|
The following links are available:
build (macOS-latest, full) build (windows-latest, full) build (ubuntu-18.04, android) |
|
Update tested. Manual noise reduction no longer default (starts automatic). Otherwise continues to function as before. |
Generally, it did a damn great job of filtering out my keystrokes though. Users that find a good number for the threshold I think will have a good time with this. Pretty much all voice applications (ever) have manual noise gates. I always use manual mode, it helps for tuning what I want to convey as an experience instead of leaving it to algorithms.