Create App: Broken Url Report #1069

AleziaKurdis · 2021-02-27T18:41:06Z

This PR add a new functionality to the Create App.

Generate Broken Url Report:

Under the "Tools" menu, we have now a "Generate Broken Url Report"

This functionality scans all the URL properties of the selected entities, it tests each of them and generates a report listing all the invalid URL found.

The following properties are covered by this functionality:
"script"
"serverScripts"
"imageURL"
"materialURL"
"modelURL"
"compoundShapeURL"
"animation.url"
"textures"
"xTextureURL"
"yTextureURL"
"zTextureURL"
"font"
"sourceUrl"
"scriptURL"
"filterURL"
"skybox.url"
"ambientLight.ambientURL"

Note:
This report is specific to HTTP URL.
This report ignores URL from the Asset Server (atp://), local drive paths or any string not starting by 'http'.

Changes to Menu bar:

The Hover color of the menu items of the menu bar have been also modified from cyan to gray since it was visually annoying when it was used over a selection of entities in the list. (disturbing cyan over cyan)

This change the hover color for the menu item of the menu bar previously it was blue-cyan as the selected entities which was visually annoying when we used the menu over a selection of entities in the list. This hover color is now a grey tonality.

AleziaKurdis · 2021-02-27T18:42:36Z

This addresses the issue #1051

vircadia-build-notifier · 2021-02-27T20:22:09Z

The following links are available:
build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1069/Vircadia-PR1069-654d04b-_65652706.dmg

build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1069/Vircadia-PR1069-654d04b-_65652706.exe

build (ubuntu-18.04, android)

The menu separator wasn't full width.

Add a Link to select the entity. So the user can edit each entity listed in the report by clicking on it. This select the entity.

AleziaKurdis · 2021-02-28T04:34:50Z

Added links in the report to select each entity directly in order to let the user to edit.

Aitolda · 2021-03-01T18:11:28Z

So I ran a report on an old domain and sure enough, 10 items came up. So far so good, though I have a couple thoughts.

I realize the entity list isn't setup this way nor would it be performant, but what would have to change to be able to create the report on all entities in the domain, regardless, rather than just what you have pointed your camera in the direction of? I should clarify that I don't think that behavior should be the norm, but specifically when running reports.
I think a quick explanation of each "status" might be handy. I know most of us are used to seeing 404 on websites, but I don't know what a zero status indicates.
Could we possibly save a copy of this report somehow?

AleziaKurdis · 2021-03-02T04:50:48Z

Now I display the Error text in addition to the Error no. (Point 2)

For the point 1 and 3:
The API is not geared to return all the entities. It's a current limitation and it would be complex to change. (If we want this, we should consider a tool to work on the model.json file of the domain directly (which is another project)

Save is not possible. (for now) It never been for security reasons. If we come to support a safe way to do it, this could be added.
A copy to clipboard could be another option but I'm not sure it would be convivial.

vircadia-build-notifier · 2021-03-02T06:32:58Z

The following links are available:
build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1069/Vircadia-PR1069-5bf40f2-_090cd176.dmg

build (ubuntu-18.04, full)

build (ubuntu-18.04, android)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1069/Vircadia-PR1069-5bf40f2-_090cd176.exe

Aitolda · 2021-03-03T18:22:18Z

Works great!

scripts/system/create/entityList/html/entityList.html

scripts/system/create/entityList/entityList.js

scripts/system/create/entityList/html/entityList.html

scripts/system/create/entityList/html/js/entityList.js

scripts/system/create/modules/brokenUrlReport.html

scripts/system/create/modules/brokenUrlReport.js

Broken Url Report - adjustments

vircadia-build-notifier · 2021-03-22T05:50:04Z

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1069/Vircadia-PR1069-1fd27ea-_0b04eee7.dmg

build (ubuntu-18.04, android)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1069/Vircadia-PR1069-1fd27ea-_0b04eee7.exe

digisomni

Seems to work alright to me. :)

Aitolda · 2021-03-30T22:40:05Z

Seems to be working as intended.

AleziaKurdis added 8 commits February 27, 2021 00:04

Add processing gif for Broken Url Report

8644325

Add Broken Url Report

9b5a1b8

Add Broken Url Report

2fd648f

Add Broken Url Report

4836fa8

Add Broken Url Report

608fe21

Add Broken Url Report functionality

6e3ab17

Add Broken Url Report feature

940b45e

Change Menu Item Highlight color

6565270

This change the hover color for the menu item of the menu bar previously it was blue-cyan as the selected entities which was visually annoying when we used the menu over a selection of entities in the list. This hover color is now a grey tonality.

digisomni added enhancement New feature or request needs CR (code review) labels Feb 27, 2021

digisomni added this to the 2021.1.1 Eos Release milestone Feb 27, 2021

AleziaKurdis added 2 commits February 27, 2021 23:30

Create App: menubar: minor css adjustment

ec04f06

The menu separator wasn't full width.

Add a Link to select the entity.

f8d93a8

Add a Link to select the entity. So the user can edit each entity listed in the report by clicking on it. This select the entity.

Aitolda added the needs testing (QA) The PR is ready for testing label Mar 1, 2021

Aitolda removed the needs testing (QA) The PR is ready for testing label Mar 1, 2021

Display the error text instead of only the no

090cd17

digisomni self-requested a review March 11, 2021 23:10

ctrlaltdavid requested changes Mar 21, 2021

View reviewed changes

digisomni removed their request for review March 21, 2021 17:13

AleziaKurdis added 4 commits March 21, 2021 22:49

Broken Url Report - adjustments

b65d31c

Broken Url Report - adjustments

Broken Url Report - adjustments

d51337c

Broken Url Report - adjustments

Broken Url Report - adjustments

ffdf196

Broken Url Report - adjustments

Broken Url Report - adjustments

0797e26

Broken Url Report - adjustments

AleziaKurdis added 3 commits March 21, 2021 22:52

Broken Url Report - adjustments

a9fadfa

Broken Url Report - adjustments

Delete brokenUrlReport.html

0da1d9a

Broken Url Report - adjustments

Delete brokenUrlReport.js

0b04eee

Broken Url Report - adjustments

AleziaKurdis requested a review from ctrlaltdavid March 22, 2021 02:54

ctrlaltdavid approved these changes Mar 22, 2021

View reviewed changes

ctrlaltdavid added CR Approved At least one code reviewer has approved the PR. needs testing (QA) The PR is ready for testing and removed needs CR (code review) labels Mar 22, 2021

digisomni modified the milestones: 2021.1.1 Eos Release, 2021.1.2 Eos Release Mar 27, 2021

digisomni approved these changes Mar 29, 2021

View reviewed changes

digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Apr 1, 2021

digisomni modified the milestones: 2021.1.2 Eos Release, 2021.1.1 Eos Release Apr 1, 2021

digisomni merged commit 519db87 into vircadia:master Apr 1, 2021

daleglass mentioned this pull request Aug 7, 2021

Feature Request: Create - Show missing entities in the entities list. #1051

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Create App: Broken Url Report #1069

Create App: Broken Url Report #1069

Uh oh!

AleziaKurdis commented Feb 27, 2021

Uh oh!

AleziaKurdis commented Feb 27, 2021

Uh oh!

vircadia-build-notifier commented Feb 27, 2021

Uh oh!

AleziaKurdis commented Feb 28, 2021

Uh oh!

Aitolda commented Mar 1, 2021 •

edited

Loading

Uh oh!

AleziaKurdis commented Mar 2, 2021

Uh oh!

vircadia-build-notifier commented Mar 2, 2021

Uh oh!

Aitolda commented Mar 3, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vircadia-build-notifier commented Mar 22, 2021

Uh oh!

digisomni left a comment

Uh oh!

Aitolda commented Mar 30, 2021

Uh oh!

Uh oh!

Create App: Broken Url Report #1069

Create App: Broken Url Report #1069

Uh oh!

Conversation

AleziaKurdis commented Feb 27, 2021

Generate Broken Url Report:

Changes to Menu bar:

Uh oh!

AleziaKurdis commented Feb 27, 2021

Uh oh!

vircadia-build-notifier commented Feb 27, 2021

Uh oh!

AleziaKurdis commented Feb 28, 2021

Uh oh!

Aitolda commented Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AleziaKurdis commented Mar 2, 2021

Uh oh!

vircadia-build-notifier commented Mar 2, 2021

Uh oh!

Aitolda commented Mar 3, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vircadia-build-notifier commented Mar 22, 2021

Uh oh!

digisomni left a comment

Choose a reason for hiding this comment

Uh oh!

Aitolda commented Mar 30, 2021

Uh oh!

Uh oh!

Aitolda commented Mar 1, 2021 •

edited

Loading