Skip to content

Fix privacy setting text #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2021
Merged

Fix privacy setting text #1071

merged 1 commit into from
Mar 4, 2021

Conversation

ctrlaltdavid
Copy link
Collaborator

@ctrlaltdavid ctrlaltdavid commented Feb 28, 2021 •
edited
Loading

Changed two occurrences of "High Fidelity" to "Vircadia".

@ctrlaltdavid ctrlaltdavid linked an issue Feb 28, 2021 that may be closed by this pull request
"Send data to High Fidelity" settings option #1059
Closed
@vircadia-build-notifier
Copy link

The following links are available:
build (macOS-latest, full)

build (ubuntu-18.04, full)

build (windows-latest, full)

build (ubuntu-18.04, android)

@digisomni
Copy link
Member

Now we just need like 10 testers on this. It could cause rampant crashing, I just know it.

@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Mar 1, 2021
@digisomni digisomni added this to the 2021.1.1 Eos Release milestone Mar 1, 2021
@daleglass
Copy link
Contributor

By the way, is this data actually going anywhere? I checked, and it should be sent to the metaverse server, to /api/v1/user_activities. Is anything accepting it?

@digisomni
Copy link
Member

Not that I know of, there's a return statement at the top of the function as well.

@digisomni digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Mar 4, 2021
digisomni
digisomni approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@digisomni digisomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked alright for me.

@digisomni digisomni merged commit 92874cf into vircadia:master Mar 4, 2021
@ctrlaltdavid ctrlaltdavid deleted the fix/setting-text branch March 5, 2021 00:35
@daleglass daleglass mentioned this pull request Apr 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daleglass daleglass daleglass approved these changes

@HifiExperiments HifiExperiments HifiExperiments approved these changes

@digisomni digisomni digisomni approved these changes

Assignees
No one assigned
Labels
bugfix CR Approved At least one code reviewer has approved the PR. QA Approved The PR has been tested successfully.
Projects
None yet
Milestone
2021.1.1 Eos Release
Development

Successfully merging this pull request may close these issues.

"Send data to High Fidelity" settings option
5 participants
@ctrlaltdavid @vircadia-build-notifier @digisomni @daleglass @HifiExperiments