Skip to content

Fix avatar parts rotating #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fix avatar parts rotating #1124

merged 1 commit into from
Apr 1, 2021

Conversation

ctrlaltdavid
Copy link
Collaborator

@ctrlaltdavid ctrlaltdavid commented Mar 28, 2021 •
edited
Loading

Possible fix for "Avatar pieces rotate in an incorrect offset sometimes", #1026 .

The easiest way I found of reproducing the problem was to clear cache and start up in a heavy domain while rotting avatar with keyboard and/or right-mouse-press-and-drag. Then, if the problem didn't occur, teleport to another heavy domain and immediately quit Interface. Then start up again there. ... and so on.

@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

build (ubuntu-18.04, android)

build (windows-latest, full)

@digisomni digisomni added this to the 2021.1.1 Eos Release milestone Mar 28, 2021
@ctrlaltdavid ctrlaltdavid added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Mar 28, 2021
@SilverfishVR
Copy link
Contributor

SilverfishVR commented Mar 29, 2021 •
edited
Loading

did not see the rotation issue yet but I'm having transparency issues (avatar is back-to-front and the plant is not transparent)🤔
Screenshot 2021-03-29 23 17 23
Screenshot 2021-03-29 23 05 59

notice that only my face is casting a shadow

❗ Edit, I see this in #1123 too, so not caused by this PR

@ctrlaltdavid
Copy link
Collaborator Author

The code changes shouldn't have anything to do with transparency or shadows. I expect that if you're having these problems with this PR build you'll probably have the same problems with other recent PR builds.

@Aitolda
Copy link
Collaborator

Aitolda commented Mar 30, 2021 •
edited
Loading

The code changes shouldn't have anything to do with transparency or shadows. I expect that if you're having these problems with this PR build you'll probably have the same problems with other recent PR builds.

I'm seeing the same thing as Silverfish. So if not this, I wonder when the bug was introduced.
4908f94767375449c318570936e002e1

EDIT: So far only seeing this on the "Woody."

@ctrlaltdavid ctrlaltdavid mentioned this pull request Mar 30, 2021
Closed
@ctrlaltdavid
Copy link
Collaborator Author

Woody and The Hub transparency problems are a separate issue: #1137

@Aitolda
Copy link
Collaborator

Aitolda commented Mar 31, 2021

Woody and The Hub transparency problems are a separate issue: #1137

On that note it seems to do what it set out to do. I can't replicate the bug on this.

@digisomni digisomni added QA Approved The PR has been tested successfully. needs testing (QA) The PR is ready for testing and removed needs testing (QA) The PR is ready for testing QA Approved The PR has been tested successfully. labels Apr 1, 2021
@digisomni digisomni linked an issue Apr 1, 2021 that may be closed by this pull request
Avatar pieces rotate in an incorrect offset sometimes #1026
Closed
@ctrlaltdavid
Copy link
Collaborator Author

To test: billboarding of entities.

@Aitolda
Copy link
Collaborator

Aitolda commented Apr 1, 2021

Billboard continues to function as expected.

@digisomni digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Apr 1, 2021
@digisomni digisomni merged commit f5b91b1 into vircadia:master Apr 1, 2021
@ctrlaltdavid ctrlaltdavid deleted the fix/avatar-parts-rotating branch April 2, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HifiExperiments HifiExperiments HifiExperiments approved these changes

Assignees
No one assigned
Labels
bugfix CR Approved At least one code reviewer has approved the PR. QA Approved The PR has been tested successfully.
Projects
None yet
Milestone
2021.1.1 Eos Release
Development

Successfully merging this pull request may close these issues.

Avatar pieces rotate in an incorrect offset sometimes
6 participants
@ctrlaltdavid @vircadia-build-notifier @SilverfishVR @Aitolda @HifiExperiments @digisomni