Skip to content

Add missing override keywords. #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2021
Merged

Add missing override keywords. #1143

merged 1 commit into from
Apr 2, 2021

Conversation

daleglass
Copy link
Contributor

Fixes warnings like:

/libraries/entities-renderer/src/RenderableTextEntityItem.h:47:18: warning: ‘virtual bool render::entities::TextEntityRenderer::needsRenderUpdate() const’ can be marked override [-Wsuggest-override]
   47 |     virtual bool needsRenderUpdate() const;
      |                  ^~~~~~~~~~~~~~~~~

@daleglass
Add missing override keywords.
6e9e119 
Fixes warnings like:

/libraries/entities-renderer/src/RenderableTextEntityItem.h:47:18: warning: ‘virtual bool render::entities::TextEntityRenderer::needsRenderUpdate() const’ can be marked override [-Wsuggest-override]
   47 |     virtual bool needsRenderUpdate() const;
      |                  ^~~~~~~~~~~~~~~~~
@daleglass daleglass requested a review from ctrlaltdavid April 1, 2021 22:27
@digisomni digisomni added the rebuild rebuild through the GithubActions label Apr 1, 2021
@vircadia-build-notifier
Copy link

The following links are available:
build (windows-latest, full)

build (ubuntu-18.04, android)

build (ubuntu-18.04, full)

build (macOS-latest, full)

@digisomni digisomni added the CR Approved At least one code reviewer has approved the PR. label Apr 2, 2021
@digisomni digisomni added this to the 2021.1.1 Eos Release milestone Apr 2, 2021
@digisomni digisomni added bugfix and removed rebuild rebuild through the GithubActions labels Apr 2, 2021
@digisomni digisomni merged commit 333e3d4 into vircadia:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HifiExperiments HifiExperiments HifiExperiments approved these changes

@ctrlaltdavid ctrlaltdavid Awaiting requested review from ctrlaltdavid

Assignees
No one assigned
Labels
bugfix CR Approved At least one code reviewer has approved the PR.
Projects
None yet
Milestone
2021.1.1 Eos Release
Development

Successfully merging this pull request may close these issues.
4 participants
@daleglass @vircadia-build-notifier @HifiExperiments @digisomni