Skip to content

Improve use of "#include <QtCore/QSharedPointer>" in codebase. #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

odysseus654
Copy link
Contributor

@odysseus654 odysseus654 commented Sep 11, 2021

This code review removes #includes for files that don't actually make use of QSharedPointer and adds them where they do.

This strengthens the codebase by:

  • removing references to unused libraries
  • removing indirect references to QSharedPointer that may be broken on removal of an "unrelated" .h file (or removal of QSharedPointer from that .h file)

(This code review sprouted out of one of the last review checks done before flagging PR 1200 as ready-to-review, the results were unrelated enough to the script engine that I figured it might be worth its own PR)

Testing focus:

  • NONE - I don't see any possible effects on the code from this change, this is strictly a compile-time and code-review/coding-style adjustment.

@digisomni digisomni added allow-build-upload Allows the upload of a build for non white-listed users enhancement New feature or request labels Sep 11, 2021
@digisomni digisomni added this to the 2021.2.0 Selene Release milestone Sep 11, 2021
@digisomni digisomni requested a review from daleglass September 16, 2021 21:06
@daleglass daleglass added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Sep 19, 2021
@digisomni digisomni merged commit 5da3f88 into vircadia:master Sep 19, 2021
@digisomni digisomni changed the title [low-priority] code review: use of "#include <QtCore/QSharedPointer>" Improve use of "#include <QtCore/QSharedPointer>" in codebase. Sep 19, 2021
@odysseus654 odysseus654 deleted the pr/QSharedPointer-review branch September 25, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-build-upload Allows the upload of a build for non white-listed users CR Approved At least one code reviewer has approved the PR. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants