Set GL preference to GLVND. #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGro
added
needs testing (QA)
|
The following links are available: build (ubuntu-18.04, full)
build (macOS-latest, full) build (windows-latest, full) |
daleglass
approved these changes
Sep 19, 2021
digisomni
added
CR Approved
|
Successfully ran by Dave K. with an Intel Mac running Big Sur. |
daleglass
added
QA Approved
|
Tested on Linux, everything looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally by daleglass.
This PR allows cmake use libOpenGL and libGLX directly instead of going through libGL. Current libGL is basically a compatibility layer for this, so nothing should change except that we save that layer. My understanding is that this might slightly improve performance. Compatibility is given for all distributions Vircadia can currently run on.
Windows is not affected by this change.
MacOS might be affected and should be tested.
The issue that we ran into in the past was that we provided libOpenGL in the AppImages which somehow broke GLVND. vircadia/vircadia-builder#73 fixes this.
The original PR is #763