Fix automatic texture memory on macOS, Android, OpenGL ES, and Intel graphics.

[JulianGro]

Fixes #1394
While this PR was made to fix automatic texture memory on macOS, it actually also fixes it on Android, OpenGL ES, and Intel graphics.

In practice this will no longer make macOS users see mega blurry textures by standard and fix the same issue on some other configurations.
The issue with automatic texture memory on Nvidia proprietary Windows is not touched by this.

I have only tested this on macOS Catalina with AMD graphics for now.

[vircadia-build-notifier]

The following links are available:
build (ubuntu-18.04, full)

• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1398/Vircadia-PR1398-712cec0-_b42170c7.sh
• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1398/Vircadia-PR1398-712cec0-.tar_b42170c7.Z
• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1398/Vircadia-PR1398-712cec0-.tar_b42170c7.gz

build (macOS-10.15, client)

• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1398/Vircadia-Interface-PR1398-712cec0-_b42170c7.dmg

build (macOS-10.15, full)

• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1398/Vircadia-PR1398-712cec0-_b42170c7.dmg

build (windows-latest, full)

• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1398/Vircadia-PR1398-712cec0-_b42170c7.exe

build (self-hosted_debian-11_aarch64, full)

• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1398/Vircadia-PR1398-712cec0-.tar_b42170c7.Z
• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1398/Vircadia-PR1398-712cec0-_b42170c7.sh
• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1398/Vircadia-PR1398-712cec0-.tar_b42170c7.gz

[digisomni]

This crashes on startup with my Mac Mini (Intel i7, iGPU). https://hastebin.com/iwaxadiwut.yaml

[JulianGro]

@digisomni can you confirm that PR builds from any other PR run?
This PR doesn't do anything that should be able to cause a crash. On Intel graphics the only change is a simple multiplication that converts from mebibytes to bytes.

[digisomni]

PR #1411 ran fine for me and that's a newer PR than this one.

[JulianGro]

PR #1411 ran fine for me and that's a newer PR than this one.

Can you try any other PR? That one likely fixes the issue.
Also do I understand it right that it crashes on startup? Not on window resize, etc.?

[digisomni]

So, I tried a couple of PR builds again (older and newer) and then tried this one again and it worked, for some odd reason.

[ArcadeFever]

This PR build worked fine for me: Macbook Pro (16-inch 2019), Intel I9, AMD graphics, Big Sur.

[Steve-Pruneau]

I am unsure whether PR 1398 is working or not. There may have been an issue with cache on my machine. The place to test this issue is at NDN World, upper floor where art works and descriptions are displayed. I got blurry images and text. I tried clearing cache (Reload Content) and also changed texture memory from automatic to 1024 and then back again. Still blurry. I also quit the app and started again. Still blurry. Then I selected Network > Clear Disk Caches, quit the app and started up again. This produced sharp images and text. iMac 27 inch. Graphics: Radeon Pro 570 4 GB. macOS 11.6 Big Sur (latest version)

[Steve-Pruneau]

My guess - it doesn't seem to harm anything. And others believe the fix works. So I say, go ahead and put it into production.

[JulianGro]

@Steve-Pruneau could you zip up your logs folder and post that here? https://docs.vircadia.com/faq.html#interface-log-files
That way we can make sure that it does actually work as intended.
The blurry textures don't necessarily mean that it didn't work as intended.
Maybe even set it to automatic again, restart Interface, and send us a log of that.

[Steve-Pruneau]

@JulianGro Unfortunately, last night, I deleted folders and files related to testing PRs. So I re-ran the test this morning. Logs attached. I think PR 1398 is working on my iMac now. I think it is because I clicked "Reset all my settings". The Interface app PR 1398 was crashing this morning when I tried to launch. So I chose the option to launch with "Reset all my settings". Then it launched smoothly. Graphics settings default to "Medium". Medium and High do not look good on Mac. Something about rendering on Mac. (I think this may not be related to PR 1398 and texture memory. In future, I think we should set graphics default "Low"). I changed graphics settings to Low. Appearance of NDN World changed immediately. This is new behavior and VERY GOOD. In past, changing graphics settings would take some number of seconds, like 15 seconds, 30 seconds or something like that to change, like slowly loading content. Upon checking upper level art work at NDN World, images are sharp (after all content is finished loading). So, I was not able to reproduce the experience yesterday. I believe "Reset all my settings" may have contributed to PR 1398 working for me now.
vircadia-log_2021-10-22_08.33.21.txt
vircadia-log_2021-10-22_08.34.09.txt
vircadia-log.txt

[JulianGro]

The logs indicate it working correctly to me as well.