Skip to content

Fix crashpad on macOS. #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

Fix crashpad on macOS. #1407

merged 1 commit into from
Oct 28, 2021

Conversation

JulianGro
Copy link
Contributor

This PR fixes finding crashpad on macOS.
Fixes #1399

@JulianGro JulianGro added needs testing (QA) The PR is ready for testing bugfix needs CR (code review) macos This is related to OSX and Mac. labels Oct 11, 2021
@digisomni digisomni added this to the 2021.2.0 Selene Release milestone Oct 11, 2021
@daleglass daleglass self-requested a review October 11, 2021 23:23
@vircadia-build-notifier
Copy link

The following links are available:
build (macOS-10.15, client)

build (ubuntu-18.04, full)

build (macOS-10.15, full)

build (windows-latest, full)

build (self-hosted_debian-11_aarch64, full)

@digisomni digisomni changed the title Fix crashpad on macOS Fix crashpad on MacOS. Oct 14, 2021
@digisomni digisomni changed the title Fix crashpad on MacOS. Fix crashpad on macOS. Oct 14, 2021
digisomni
digisomni approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@digisomni digisomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on Windows 10, built from source.

@daleglass
Copy link
Contributor

So this is an easy fix and looks like a no-brainer, but it still confuses me why it worked on Windows without the cdUp.

Unfortunately I wasn't able to test this on Windows because I only have a VM available right now, and it fails too quickly.

@digisomni Did you test triggering a crash and seeing if a report is made?

@JulianGro
Copy link
Contributor Author

JulianGro commented Oct 23, 2021 •
edited
Loading

Unfortunately I wasn't able to test this on Windows because I only have a VM available right now, and it fails too quickly.

You have tried looking in the command line, right?
Crashpad is almost the first this that gets loaded. We are talking in the first 3-5 messages. That is when it would throw an error.

Or I guess you want to go all the way with the test and actually send a crash to Sentry.

@daleglass
Copy link
Contributor

Yes, of course. Unfortunately I get no console output, and it doesn't seem to get to the point of writing to the log file.

This is probably fixable but I'll probably need to fiddle with something to build interface as a commandline application so that it actually outputs to the terminal.

@daleglass
Copy link
Contributor

interface_in_vm

@daleglass daleglass merged commit 4d190df into vircadia:master Oct 28, 2021
@JulianGro JulianGro deleted the macOS_fix_crashpad branch October 29, 2021 18:15
@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs testing (QA) The PR is ready for testing needs CR (code review) labels Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daleglass daleglass daleglass approved these changes

@digisomni digisomni digisomni approved these changes

Assignees
No one assigned
Labels
bugfix CR Approved At least one code reviewer has approved the PR. macos This is related to OSX and Mac.
Projects
None yet
Milestone
2022.1.0 Selene Release
Development

Successfully merging this pull request may close these issues.

macOS crashpad_handler is being searched in wrong path
4 participants
@JulianGro @vircadia-build-notifier @daleglass @digisomni