Changed preset framerates; Add "low power" preset. #1422

Penguin-Guru · 2021-10-23T17:17:46Z

No description provided.

ksuprynowicz · 2021-10-23T17:19:15Z

Awesome :)
I will test it later today

vircadia-build-notifier · 2021-10-23T19:30:05Z

The following links are available:
build (macOS-10.15, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1422/Vircadia-Interface-PR1422-c1540e8-_412aa4e9.dmg

build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1422/Vircadia-PR1422-c1540e8-_412aa4e9.exe

build (self-hosted_debian-11_aarch64, full)

interface/src/PerformanceManager.cpp

HifiExperiments

I love this solution!

Penguin-Guru · 2021-10-24T04:14:30Z

It was ksuprynowicz's idea. Give him the credit. :p

ksuprynowicz · 2021-10-24T07:17:03Z

It was ksuprynowicz's idea. Give him the credit. :p

Nah, I just wanted to switch off frame limiter on all presets. Kalila recommended adding power saving mode :)

ksuprynowicz · 2021-10-25T09:01:16Z

Everything works correctly on Linux

ksuprynowicz · 2021-10-25T09:02:48Z

I think we should test and merge this PR before doing a release. Current frame limiter on Medium and Low is very confusing.

digisomni · 2021-10-30T07:16:33Z

I'm on Windows 10, there's an issue where "High" gets the minimum possible resolution scale.

ksuprynowicz · 2021-10-30T11:14:46Z

I just built and tested it on Windows 10, and I'm unable to replicate the problem. Resolution scale is always 1.0 for me in presets:

Penguin-Guru · 2021-10-30T13:46:03Z

I'm on Windows 10, there's an issue where "High" gets the minimum possible resolution scale.

I'm not sure how the changes I made could have caused this. Does it occur consistently after a clean build? No scripts that might be affecting it?

interface/src/PerformanceManager.cpp

daleglass · 2021-10-30T17:40:12Z

interface/src/PerformanceManager.cpp

        default:
-            // Do nothing anymore
+            // Do nothing.


Is there any reasonable way of getting here? There should either be no default for a compile-time warning, or a warning log instead.

I don't know what UNKNOWN was intended for. I didn't really look into it but I don't remember seeing it used anywhere. It's not even the default mode. It wasn't related to this PR though so I didn't want to make too many unnecessary changes. Might be good to try logging it for a while and see if the log ever appears? If not, then remove it?

Yeah, I think a log would be good here. I don't think anything should be reaching this point legitimately.

digisomni · 2021-10-30T17:46:17Z

A fresh install with a fresh configuration yields the same results.

OS Name Microsoft Windows 10 Pro
Version 10.0.19042 Build 19042
Adapter Description NVIDIA GeForce RTX 3060 Ti
Driver Version 30.0.14.7196

ksuprynowicz · 2021-10-30T17:48:00Z

A fresh install with a fresh configuration yields the same results.

Can you try from different Windows user account?

Penguin-Guru · 2021-10-30T18:06:22Z

A fresh install with a fresh configuration yields the same results.

OS Name Microsoft Windows 10 Pro Version 10.0.19042 Build 19042 Adapter Description NVIDIA GeForce RTX 3060 Ti Driver Version 30.0.14.7196

So the Resolution Scale is set to minimum when you switch to HIGH (and only HIGH)? Does it change when you switch to any other preset after that?

digisomni · 2021-10-30T18:09:10Z

A fresh install with a fresh configuration yields the same results.
OS Name Microsoft Windows 10 Pro Version 10.0.19042 Build 19042 Adapter Description NVIDIA GeForce RTX 3060 Ti Driver Version 30.0.14.7196

So the Resolution Scale is set to minimum when you switch to HIGH (and only HIGH)? Does it change when you switch to any other preset after that?

Yeah, it goes back to a normal 1.0 scale for the other options.

Penguin-Guru · 2021-10-30T18:28:56Z

I'm compiling something to test. Will push for you to test if it works for me.

Penguin-Guru · 2021-10-30T18:48:14Z

Can you test with that change?

ctrlaltdavid · 2021-10-30T18:49:53Z

Regarding the low resolution for HIGH setting, see the following line in PerformanceManager::applyPerformancePreset():

const float RECOMMANDED_PPI[] = { 200.0f, 120.f, 160.f, 250.f};

Penguin-Guru · 2021-10-30T18:52:00Z

Regarding the low resolution for HIGH setting, see the following line in PerformanceManager::applyPerformancePreset():
const float RECOMMANDED_PPI[] = { 200.0f, 120.f, 160.f, 250.f};

Yeah, I just pushed that change to test. I'm not sure why the problem didn't occur for me or ksuprynowicz though. Maybe bad luck with our monitors?

digisomni · 2021-10-30T20:05:06Z

Once it builds then I will give it a shot. :)

vircadia-build-notifier · 2021-10-31T01:15:06Z

The following links are available:
build (macOS-10.15, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1422/Vircadia-Interface-PR1422-9f1bdf8-_02126869.dmg

build (macOS-10.15, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1422/Vircadia-PR1422-9f1bdf8-_02126869.dmg

build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1422/Vircadia-PR1422-9f1bdf8-_02126869.exe

build (self-hosted_debian-11_aarch64, full)

digisomni · 2021-10-31T06:46:42Z

The issue appears to be solved now. Can anyone else download a copy from GH and check to confirm as well?

ksuprynowicz · 2021-11-04T10:59:48Z

The issue appears to be solved now. Can anyone else download a copy from GH and check to confirm as well?

I just tested it on Windows 10, and it works perfectly, both in VR and in Desktop mode

daleglass · 2021-11-06T00:24:49Z

interface/src/PerformanceManager.cpp

        default:
-            // Do nothing anymore
+            // Do nothing.


Yeah, I think a log would be good here. I don't think anything should be reaching this point legitimately.

Penguin-Guru · 2021-11-06T01:12:17Z

I could add the logging now but I wouldn't be able to test it for several days and it's kind of outside the scope of this P.R. I think it would be better if someone makes the change outside of this P.R. If you do want it here, feel free to make the change yourself. Edits by maintainers is enabled.

digisomni added allow-build-upload Allows the upload of a build for non white-listed users enhancement New feature or request needs CR (code review) labels Oct 23, 2021

digisomni added this to the 2021.2.0 Selene Release milestone Oct 23, 2021

digisomni changed the title ~~Changed preset framerates. Added preset.~~ Changed preset framerates; Add "low-power" preset. Oct 23, 2021

digisomni changed the title ~~Changed preset framerates; Add "low-power" preset.~~ Changed preset framerates; Add "low power" preset. Oct 23, 2021

HifiExperiments reviewed Oct 24, 2021

View reviewed changes

interface/src/PerformanceManager.cpp Outdated Show resolved Hide resolved

HifiExperiments reviewed Oct 24, 2021

View reviewed changes

HifiExperiments approved these changes Oct 24, 2021

View reviewed changes

digisomni added CR Approved At least one code reviewer has approved the PR. needs testing (QA) The PR is ready for testing and removed needs CR (code review) labels Oct 25, 2021

daleglass suggested changes Oct 30, 2021

View reviewed changes

interface/src/PerformanceManager.cpp Outdated Show resolved Hide resolved

interface/src/PerformanceManager.cpp Outdated Show resolved Hide resolved

digisomni added needs CR (code review) and removed CR Approved At least one code reviewer has approved the PR. labels Oct 30, 2021

daleglass suggested changes Oct 30, 2021

View reviewed changes

digisomni linked an issue Oct 30, 2021 that may be closed by this pull request

The default graphics setting of 'Low' is awful -- it throttles framerate and causes weird motion #18

Closed

Penguin-Guru added 4 commits October 30, 2021 12:57

Changed preset framerates. Added preset.

56bc962

Removed typo newline.

727ac38

Maybe this helps?

6dd26c5

Adjusted for rebase on typo correction.

0212686

Penguin-Guru force-pushed the master branch from a71af96 to 0212686 Compare October 30, 2021 20:02

digisomni requested a review from daleglass November 1, 2021 21:40

digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Nov 4, 2021

daleglass approved these changes Nov 6, 2021

View reviewed changes

digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Nov 6, 2021

daleglass merged commit 35a420d into vircadia:master Nov 6, 2021

Changed preset framerates; Add "low power" preset. #1422

Changed preset framerates; Add "low power" preset. #1422

Uh oh!

Conversation

Penguin-Guru commented Oct 23, 2021

Uh oh!

ksuprynowicz commented Oct 23, 2021

Uh oh!

vircadia-build-notifier commented Oct 23, 2021

Uh oh!

Uh oh!

HifiExperiments left a comment

Choose a reason for hiding this comment

Uh oh!

Penguin-Guru commented Oct 24, 2021

Uh oh!

ksuprynowicz commented Oct 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ksuprynowicz commented Oct 25, 2021

Uh oh!

ksuprynowicz commented Oct 25, 2021

Uh oh!

digisomni commented Oct 30, 2021

Uh oh!

ksuprynowicz commented Oct 30, 2021

Uh oh!

Penguin-Guru commented Oct 30, 2021

Uh oh!

Uh oh!

Uh oh!

daleglass Oct 30, 2021

Choose a reason for hiding this comment

Uh oh!

Penguin-Guru Oct 30, 2021

Choose a reason for hiding this comment

Uh oh!

daleglass Nov 6, 2021

Choose a reason for hiding this comment

Uh oh!

digisomni commented Oct 30, 2021

Uh oh!

ksuprynowicz commented Oct 30, 2021

Uh oh!

Penguin-Guru commented Oct 30, 2021

Uh oh!

digisomni commented Oct 30, 2021

Uh oh!

Penguin-Guru commented Oct 30, 2021

Uh oh!

Penguin-Guru commented Oct 30, 2021

Uh oh!

ctrlaltdavid commented Oct 30, 2021

Uh oh!

Penguin-Guru commented Oct 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

digisomni commented Oct 30, 2021

Uh oh!

vircadia-build-notifier commented Oct 31, 2021

Uh oh!

digisomni commented Oct 31, 2021

Uh oh!

ksuprynowicz commented Nov 4, 2021

Uh oh!

daleglass Nov 6, 2021

Choose a reason for hiding this comment

Uh oh!

Penguin-Guru commented Nov 6, 2021

Uh oh!

Uh oh!

ksuprynowicz commented Oct 24, 2021 •

edited

Loading

Penguin-Guru commented Oct 30, 2021 •

edited

Loading