Skip to content

Require OpenSSL 1.1.0 during CMake. #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2021

Conversation

daleglass
Copy link
Contributor

Earlier versions don't work with WebRTC, and cause linking errors.

OpenSSL 1.1 is supported in Ubuntu 18.04, although 1.0 can still be installed, which will cause the build to fail. This change ensures the issue is detected right in cmake rather than having the build explode later.

Testing:

Test on Ubuntu 18.04, with OpenSSL 1.0 installed (libssl1.0-dev present, libssl-dev not present)

Before this change, cmake will say something like:

-- Found OpenSSL: /usr/lib64/libcrypto.so (found version "1.0.2n")  

and the build will probably fail with:

../libraries/networking/libnetworking.so: undefined reference to `BIO_meth_new'
../libraries/networking/libnetworking.so: undefined reference to `OPENSSL_init_crypto'
../libraries/networking/libnetworking.so: undefined reference to `OPENSSL_init_ssl'
../libraries/networking/libnetworking.so: undefined reference to `BIO_meth_set_write'
../libraries/networking/libnetworking.so: undefined reference to `BIO_set_data'
../libraries/networking/libnetworking.so: undefined reference to `BIO_meth_set_ctrl'
../libraries/networking/libnetworking.so: undefined reference to `BIO_meth_set_puts'
../libraries/networking/libnetworking.so: undefined reference to `BIO_get_data'
../libraries/networking/libnetworking.so: undefined reference to `BIO_set_init'
../libraries/networking/libnetworking.so: undefined reference to `BIO_set_shutdown'
../libraries/networking/libnetworking.so: undefined reference to `BIO_meth_set_create'
../libraries/networking/libnetworking.so: undefined reference to `HMAC_CTX_free'
../libraries/networking/libnetworking.so: undefined reference to `SSL_CTX_up_ref'
../libraries/networking/libnetworking.so: undefined reference to `EVP_MD_CTX_reset'
../libraries/networking/libnetworking.so: undefined reference to `EVP_MD_CTX_new'
../libraries/networking/libnetworking.so: undefined reference to `BIO_meth_set_destroy'
../libraries/networking/libnetworking.so: undefined reference to `EVP_MD_CTX_free'
../libraries/networking/libnetworking.so: undefined reference to `SSL_session_reused'
../libraries/networking/libnetworking.so: undefined reference to `X509_getm_notBefore'
../libraries/networking/libnetworking.so: undefined reference to `TLS_method'
../libraries/networking/libnetworking.so: undefined reference to `EVP_PKEY_up_ref'
../libraries/networking/libnetworking.so: undefined reference to `X509_up_ref'
../libraries/networking/libnetworking.so: undefined reference to `HMAC_CTX_new'
../libraries/networking/libnetworking.so: undefined reference to `X509_getm_notAfter'
../libraries/networking/libnetworking.so: undefined reference to `X509_STORE_CTX_get0_cert'
../libraries/networking/libnetworking.so: undefined reference to `BIO_meth_set_read'

With this change, cmake will say:

-- Found OpenSSL: /usr/lib64/libcrypto.so (found suitable version "1.1.1l", minimum required is "1.1.0")  

And should work correctly.

This should make no difference at all on any recent Linux distribution.

Earlier versions don't work with WebRTC, and cause linking errors.

OpenSSL 1.1 is supported in Ubuntu 18.04, although 1.0 can still be
installed.
@daleglass daleglass added CMake linux This is related to Linux. needs CR (code review) needs testing (QA) The PR is ready for testing labels Nov 4, 2021
@digisomni digisomni changed the title Require OpenSSL 1.1.0 at the very least Require OpenSSL 1.1.0 in CMake. Nov 4, 2021
@digisomni digisomni added enhancement New feature or request rebuild rebuild through the GithubActions labels Nov 4, 2021
@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs testing (QA) The PR is ready for testing needs CR (code review) labels Nov 6, 2021
@digisomni digisomni removed the rebuild rebuild through the GithubActions label Nov 6, 2021
@digisomni digisomni changed the title Require OpenSSL 1.1.0 in CMake. Require OpenSSL 1.1.0 during CMake. Nov 6, 2021
@daleglass daleglass merged commit a95b4f4 into vircadia:master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CR Approved At least one code reviewer has approved the PR. enhancement New feature or request linux This is related to Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants