Require OpenSSL 1.1.0 during CMake. #1436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions don't work with WebRTC, and cause linking errors.
OpenSSL 1.1 is supported in Ubuntu 18.04, although 1.0 can still be installed, which will cause the build to fail. This change ensures the issue is detected right in cmake rather than having the build explode later.
Testing:
Test on Ubuntu 18.04, with OpenSSL 1.0 installed (
libssl1.0-dev
present,libssl-dev
not present)Before this change, cmake will say something like:
and the build will probably fail with:
With this change, cmake will say:
And should work correctly.
This should make no difference at all on any recent Linux distribution.