Skip to content

Remove "Console" options from Interface-only installer (Windows) #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 20, 2020
Merged

Remove "Console" options from Interface-only installer (Windows) #824

merged 7 commits into from
Dec 20, 2020

Conversation

ctrlaltdavid
Copy link
Collaborator

@ctrlaltdavid ctrlaltdavid commented Oct 18, 2020 •
edited
Loading

The advanced tab of the Windows Interface-only installer had three "console" advanced install options. These related to a cut-down version of the Sandbox's Windows system tray icon, with options (e.g., "GoTo") the currently don't work properly.

This PR temporarily removes the three "console" options from the Interface-only advanced install options and no longer creates a "Console" start menu item - until such time as the "console" is fixed (and perhaps renamed) or it's decided that it should be removed permanently. See issue: #683

Note: The Console is still installed - just the same as if only "Interface" is enabled for installation in the combined Interface+Sandbox installer.

Also:

  • Renames the installer build instructions from INSTALL.md to INSTALLER.md.
  • Fixes use of the BYPASS_SIGNING flag, used for bypassing the signing of Windows production builds.

This was linked to issues Oct 18, 2020
Windows separate Interface and Sandbox? #649
Closed
Trying to make Production Build on Windows w/out code signing certs fails #783
Closed
@ctrlaltdavid
Copy link
Collaborator Author

ctrlaltdavid commented Oct 18, 2020 •
edited
Loading

Testing

1) Interface-only and Interface + Sandbox installers

Build 2 installers:

  • Interface-only
  • Interface + Sandbox
    Note: You can do set BYPASS_SIGNING=1 to set an environment variable to bypass signing the installers.

Test Interface-only installer:

  • Express install works:
    • Installs Interface.
    • Doesn't install domain server - domain-server.exe is not present in the install directory.
    • Interface runs.
  • Custom install works:
    • There are no "Console" checkbox items present in the advanced options.
    • Installs Interface.
    • Doesn't install domain server - domain-server.exe is not present in the install directory.
    • Interface runs.

Test Interface + Sandbox installer:

  • The 3 "Sandbox" checkbox items are present.
  • Express install works as expected.
  • Custom install works as expected. In particular, the Sandbox server is installed or not installed, and run or not run, per checkbox items.

2) Signed production build

Check that a signed release-for-production build can still be built.

@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

build (windows-latest, full)

@two-one-five
Copy link
Contributor

Made a PR installer only build and indeed a shortcut was created even though on the custom install section there was no option (Which is good) for that. Also a server-console folder with a server-console.exe is present in the install directory, it does run, though there is no domain-server so it doesn't exactly do much...

image

@ctrlaltdavid
Copy link
Collaborator Author

Yes, it has the same behaviour as installing only Interface from combined Interface+Sandbox installer. Whether or not the Console app should be called something else, have its current Interface-only items (and fix their operation), or perhaps not be installed in Interface-only installations is a separate issue, I think. This PR is just addressing the need for Interface-only installer not having a confusing "Console" option - to make it easier for the likes of Steve to guide end users in set-up.

@two-one-five
Copy link
Contributor

Yes, it has the same behaviour as installing only Interface from combined Interface+Sandbox installer. Whether or not the Console app should be called something else, have its current Interface-only items (and fix their operation), or perhaps not be installed in Interface-only installations is a separate issue, I think. This PR is just addressing the need for Interface-only installer not having a confusing "Console" option - to make it easier for the likes of Steve to guide end users in set-up.

That works pretty well I expect, the only thing I can think of is does that shortcut show up in the Interface-Only build on MacOS? That's the part that gets people. :)

@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

build (windows-latest, full)

@two-one-five two-one-five added the needs testing (QA) The PR is ready for testing label Oct 29, 2020
@two-one-five two-one-five added this to the 2020.3.2 Release milestone Oct 30, 2020
@two-one-five
Copy link
Contributor

I gave it a test on Mac and I still see it.
image
I used the parameter -DCLIENT_ONLY=1

@ctrlaltdavid
Copy link
Collaborator Author

Did you install over the top or do a clean install?

What is the screen shot showing exactly? I.e., what is the Windows equivalent?
The Console is still build and installed on Windows, but the Console is not prompted about during installation and no Console items are created in the Start Menu or on the desktop.

@ctrlaltdavid
Copy link
Collaborator Author

The problematic "Console" icon probably comes about when generating the DMG, though I've not been able to see where this icons are generated. (I don't use Mac, which doesn't help.) Note also the lower-case "i" in "interface".

@two-one-five
Copy link
Contributor

Let's try and get "interface" to say "Vircadia" and merge this as is. :)

digisomni
digisomni approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@digisomni digisomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine on Windows for me.

@digisomni digisomni changed the title Remove "Console" options from Interface-only installer Remove "Console" options from Interface-only installer (Windows) Dec 17, 2020
@digisomni digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Dec 17, 2020
@ctrlaltdavid ctrlaltdavid added needs testing (QA) The PR is ready for testing and removed QA Approved The PR has been tested successfully. labels Dec 18, 2020
@vircadia-build-notifier
Copy link

The following links are available:
build (macOS-latest, full)

build (ubuntu-18.04, full)

build (ubuntu-18.04, android)

build (windows-latest, full)

@digisomni digisomni added QA Approved The PR has been tested successfully. and removed needs CR (code review) needs testing (QA) The PR is ready for testing labels Dec 20, 2020
@digisomni digisomni merged commit f1576ab into vircadia:master Dec 20, 2020
@ctrlaltdavid ctrlaltdavid deleted the fix/interface-console branch December 20, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digisomni digisomni digisomni approved these changes

@two-one-five two-one-five Awaiting requested review from two-one-five

Assignees
No one assigned
Labels
bugfix enhancement New feature or request QA Approved The PR has been tested successfully.
Projects
None yet
Milestone
2020.3.3 Release
Development

Successfully merging this pull request may close these issues.

Trying to make Production Build on Windows w/out code signing certs fails Windows separate Interface and Sandbox?
4 participants
@ctrlaltdavid @vircadia-build-notifier @two-one-five @digisomni