HUD overlay fixes and improvements #838

ctrlaltdavid · 2020-10-24T08:42:11Z

The VR HUD overlay has been fixed and improved:

Overlay surface is rendered a bit further away (1.5m instead of 1.0m). This makes it easier on the eyes.
The horizontal size of the overlay surface has been reduced from 270 deg to 180 deg. This means that it doesn't wrap around "behind" you.
The physical (real world) distance required to move before the HUD overlay is recentered on your avatar has been reduced from 0.99m to 0.33m. This makes the HUD always be reasonably centred on your view rather than possibly being very offset at times.
Reorienting the overlay surface to better suit your current HMD orientation (i.e., be reasonably well centred on your current view) has been enabled. This means that the HUD overlay can no longer be behind you.
Fix un-pinned HUD content (e.g., Web browser window) displaying only every second recentering.
Fix laser intersection with HUD overlay dialogs / windows: laser intersects exactly per dialog position and size. This, for example, means that you can now drag dialogs using their top margin.
Fix the position of the dialog / window resize outline, displayed when resizing a dialog / window - in both desktop and HMD mode.

ctrlaltdavid · 2020-10-24T08:42:41Z

Testing

HMD mode ...

The position and orientation of the HUD overlay can most readily be seen if you display the chat bar down the bottom of the screen. (Press Enter to display.)
The browser window (Ctrl-B) can also be useful for testing.

Test that the HUD overlay repositions to be centered on your avatar as you move about your physical VR play space.
Test that the HUD overlay reorients to be reasonably in front of the direction you're facing. (Rotate your head about the y axis and the overlay will jump to follow your gaze as it reaches the edge of the overlay.)
Test laser on HUD items:

Laser end point coincides with HUD items.
Laser hovers controls on HUD surface (e.g., "x" button in script debug window).
Laser click works on HUD surface (e.g., click-and-drag script debug window, "x" button in script debug window closes window).
You can reposition dialogs / windows by dragging in their top margin (in addition to their bottom margin).

Test mouse pointer on HUD surface:

... per laser testing.

Dialogs and windows' resize outline now displays in the correct place (i.e., not jumped up from the dialog / window). In both desktop and HMD modes.

vircadia-build-notifier · 2020-10-24T10:17:15Z

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR838/Vircadia-Alpha-PR838-65ec822_cbef9d29.dmg

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR838/Vircadia-Alpha-PR838-65ec822_cbef9d29.exe

libraries/display-plugins/src/display-plugins/CompositorHelper.cpp

interface/src/ui/OverlayConductor.cpp

SilverfishVR · 2020-11-05T22:46:21Z

Overall there are improvements and nothing seems to have broken, the hud still has issues and bugs though.
random observations.

recentering and reorientation is a lot better, I think I would prefer it if recenter worked the same for real world movement as it does for controller movement, being locked to avatar Y orientation/position instead of snapping.
the scale and distance looks good to me.
Intersecting (laser) the window border (close, pin, resize) still only works sporadically, it initially worked for me but now it seems mostly broken (as is normal).
scrollbars in hud windows seems to move the window when lasered, instead of actual scrolling.
the microphone overlay always work, I can move and click it as expected 😃
sometimes, the recenter is slow (or glitchy) so if I turn around, the windows may disappear for a 2-5 seconds 🤔
we need to figure out what the pin is supossed to do.

tl:dr the changes in this PR all seems to work 👍 but more fixes (or redesign) is needed to make it good

ctrlaltdavid · 2020-11-12T07:56:34Z

Laser intersecting is worse than before. Not obvious why but I'm working on it.

Also fixes dialog resize outline being drawn in the wrong position (desktop and HMD).

vircadia-build-notifier · 2020-11-23T04:41:19Z

The following links are available:
build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR838/Vircadia-Alpha-PR838-fd9702e_b865e9bc.dmg

build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR838/Vircadia-Alpha-PR838-fd9702e_b865e9bc.exe

SilverfishVR · 2020-11-25T18:32:26Z

For the first time ever, laser intersecting works as expected now 👍

if the windows are supposed to disappear when moving if not pinned that still don't work, not sure I miss it though 🤷
the scrollbar on the browser works, the one on the debug window does not, it grabs and moves instead.
the windows still disappear for a few seconds sometimes, they always come back quickly so definitely improved.

All in all, this PR does indeed fix & improve the HUD so I approve 👍 And thank you for the contribution 😄

ctrlaltdavid · 2020-11-25T19:09:58Z

The window disappearing sometimes for a few seconds is the windows disappearing when (Interface thinks) you've moving. Windows that are pinned don't disappear, though.

Scrollbar on the debug window, I'll have a look at.

ctrlaltdavid · 2020-11-30T18:20:08Z

I've created a separate issue for the script log window's scrollbar: #892

vircadia-build-notifier · 2020-12-04T00:18:25Z

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR838/Vircadia-Alpha-PR838-8e70e1b_b865e9bc.dmg

build (ubuntu-18.04, android)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR838/Vircadia-Alpha-PR838-8e70e1b_b865e9bc.exe

ctrlaltdavid added 6 commits October 24, 2020 16:00

Increase HUD overlay radius

436bed3

Make default reticle depth be HUD overlay radius

4d70651

Reduce horizontal size of HUD overlay from 270 deg to 180 deg

01cd4aa

Reduce "center UI" trigger distance from 0.99m to 0.33m

d2b15d7

Enable "center UI" to be triggered on rotation

9f95b10

Fix HUD content displaying only every second HUD recentering

cbef9d2

ctrlaltdavid added bug Something isn't working enhancement New feature or request needs CR (code review) labels Oct 24, 2020

ctrlaltdavid linked an issue Oct 24, 2020 that may be closed by this pull request

Fix VR HUD to correctly follow user's orientation. #732

Closed

two-one-five added this to the 2020.3.2 Release milestone Oct 24, 2020

two-one-five added bugfix and removed bug Something isn't working labels Oct 24, 2020

two-one-five requested a review from HifiExperiments October 29, 2020 21:50

HifiExperiments suggested changes Oct 29, 2020

View reviewed changes

libraries/display-plugins/src/display-plugins/CompositorHelper.cpp Show resolved Hide resolved

interface/src/ui/OverlayConductor.cpp Show resolved Hide resolved

ctrlaltdavid requested a review from HifiExperiments October 31, 2020 00:49

HifiExperiments approved these changes Oct 31, 2020

View reviewed changes

ctrlaltdavid added needs testing (QA) The PR is ready for testing CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Oct 31, 2020

Merge branch 'master' into fix/hud-recentering

2cfd2c8

two-one-five added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Nov 12, 2020

ctrlaltdavid added the do not merge do not merge due to issues or pending updates label Nov 12, 2020

two-one-five removed the QA Approved The PR has been tested successfully. label Nov 12, 2020

two-one-five removed this from the 2020.3.2 Release milestone Nov 12, 2020

two-one-five added this to the 2020.3.3 Release milestone Nov 12, 2020

Fix laser intersection with HUD overlay dialogs

b865e9b

Also fixes dialog resize outline being drawn in the wrong position (desktop and HMD).

ctrlaltdavid added needs CR (code review) needs testing (QA) The PR is ready for testing and removed CR Approved At least one code reviewer has approved the PR. do not merge do not merge due to issues or pending updates labels Nov 23, 2020

two-one-five requested a review from HifiExperiments December 3, 2020 22:25

two-one-five added the rebuild rebuild through the GithubActions label Dec 3, 2020

HifiExperiments approved these changes Dec 14, 2020

View reviewed changes

digisomni added CR Approved At least one code reviewer has approved the PR. QA Approved The PR has been tested successfully. and removed needs CR (code review) needs testing (QA) The PR is ready for testing labels Dec 15, 2020

digisomni merged commit 0f87e4c into vircadia:master Dec 15, 2020

ctrlaltdavid deleted the fix/hud-recentering branch December 15, 2020 04:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HUD overlay fixes and improvements #838

HUD overlay fixes and improvements #838

Uh oh!

ctrlaltdavid commented Oct 24, 2020 •

edited

Loading

Uh oh!

ctrlaltdavid commented Oct 24, 2020 •

edited

Loading

Uh oh!

vircadia-build-notifier commented Oct 24, 2020

Uh oh!

Uh oh!

Uh oh!

SilverfishVR commented Nov 5, 2020

Uh oh!

ctrlaltdavid commented Nov 12, 2020

Uh oh!

vircadia-build-notifier commented Nov 23, 2020

Uh oh!

SilverfishVR commented Nov 25, 2020

Uh oh!

ctrlaltdavid commented Nov 25, 2020

Uh oh!

ctrlaltdavid commented Nov 30, 2020

Uh oh!

vircadia-build-notifier commented Dec 4, 2020

Uh oh!

Uh oh!

HUD overlay fixes and improvements #838

HUD overlay fixes and improvements #838

Uh oh!

Conversation

ctrlaltdavid commented Oct 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ctrlaltdavid commented Oct 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

vircadia-build-notifier commented Oct 24, 2020

Uh oh!

Uh oh!

Uh oh!

SilverfishVR commented Nov 5, 2020

Uh oh!

ctrlaltdavid commented Nov 12, 2020

Uh oh!

vircadia-build-notifier commented Nov 23, 2020

Uh oh!

SilverfishVR commented Nov 25, 2020

Uh oh!

ctrlaltdavid commented Nov 25, 2020

Uh oh!

ctrlaltdavid commented Nov 30, 2020

Uh oh!

vircadia-build-notifier commented Dec 4, 2020

Uh oh!

Uh oh!

ctrlaltdavid commented Oct 24, 2020 •

edited

Loading

ctrlaltdavid commented Oct 24, 2020 •

edited

Loading