Skip to content

Fix alt key on Linux #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

Fix alt key on Linux #860

merged 1 commit into from
Dec 10, 2020

Conversation

makinori
Copy link
Contributor

@makinori makinori commented Nov 12, 2020 •
edited
Loading

Deleted old GLWidget code that breaks alt which has been in use with Tivoli since September 17 without any issues. The problem is along the lines of the window menu bar capturing alt instead, which has long been fixed by Qt.

@two-one-five two-one-five added allow-build-upload Allows the upload of a build for non white-listed users needs CR (code review) labels Nov 12, 2020
@two-one-five two-one-five added this to the 2020.3.3 Release milestone Nov 12, 2020
daleglass
daleglass approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@daleglass daleglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, needs testing.

@daleglass daleglass added the needs testing (QA) The PR is ready for testing label Nov 12, 2020
@two-one-five two-one-five added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Nov 12, 2020
@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

build (windows-latest, full)

@JulianGro
Copy link
Contributor

I can confirm that this works on Linux Mint 19.3.
Holding alt allows you to circle around a focused point and zoom in and out.
Holding ctrl + alt allows you to look up and down as well as circle around.

@two-one-five
Copy link
Contributor

Awesomeness, I'll merge this after confirming that it doesn't break anything on Windows. :)

@daleglass daleglass merged commit 70f2866 into vircadia:master Dec 10, 2020
@makinori makinori deleted the fix-alt-on-linux branch December 20, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daleglass daleglass daleglass approved these changes

Assignees
No one assigned
Labels
allow-build-upload Allows the upload of a build for non white-listed users CR Approved At least one code reviewer has approved the PR. needs testing (QA) The PR is ready for testing
Projects
None yet
Milestone
2020.3.3 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@makinori @vircadia-build-notifier @JulianGro @two-one-five @daleglass