Skip to content

Enable crash reporting on PR builds from GHA #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 15, 2020
Merged

Enable crash reporting on PR builds from GHA #878

merged 4 commits into from
Dec 15, 2020

Conversation

two-one-five
Copy link
Contributor

Testing...

@two-one-five two-one-five added enhancement New feature or request do not merge do not merge due to issues or pending updates labels Nov 20, 2020
@two-one-five two-one-five added this to the 2020.3.2 Release milestone Nov 20, 2020
@vircadia-build-notifier
Copy link

The following links are available:
build (macOS-latest, full)

build (ubuntu-18.04, full)

build (windows-latest, full)

@two-one-five
Copy link
Contributor Author

QA: So I can confirm this does work. However, the crash logs are... of eh usefulness unless the debug files are uploaded. But I haven't figured out a way to self clean that S3 of old debug files... so PR builds will load that up real fast and I won't have the best way to handle that. Mayhaps something that deletes things older than 180 days, dunno.

@two-one-five two-one-five added needs CR (code review) and removed do not merge do not merge due to issues or pending updates labels Nov 20, 2020
ctrlaltdavid
ctrlaltdavid reviewed Nov 20, 2020
View reviewed changes
Copy link
Collaborator

@ctrlaltdavid ctrlaltdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a comment above these lines along the lines of, "enable Sentry crash reporting".

@two-one-five
Copy link
Contributor Author

Perhaps add a comment above these lines along the lines of, "enable Sentry crash reporting".

Done! :)

@two-one-five two-one-five linked an issue Nov 21, 2020 that may be closed by this pull request
Add Sentry crash reporting to GHA #875
Open
@ctrlaltdavid ctrlaltdavid self-requested a review November 21, 2020 19:47
@ctrlaltdavid ctrlaltdavid added the CR Approved At least one code reviewer has approved the PR. label Nov 21, 2020
@vircadia-build-notifier
Copy link

The following links are available:
build (macOS-latest, full)

build (ubuntu-18.04, full)

build (windows-latest, full)

@ctrlaltdavid ctrlaltdavid added needs testing (QA) The PR is ready for testing and removed needs CR (code review) labels Nov 22, 2020
HifiExperiments
HifiExperiments reviewed Nov 24, 2020
View reviewed changes
@two-one-five
Copy link
Contributor Author

I will add the token to the GHA env variables, and I will also document all the required environment variables somewhere so people know how to get GHA running just like that.

@digisomni digisomni added the rebuild rebuild through the GithubActions label Dec 12, 2020
@vircadia-build-notifier
Copy link

The following links are available:
build (macOS-latest, full)

build (ubuntu-18.04, full)

build (windows-latest, full)

@digisomni digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Dec 15, 2020
@digisomni
Copy link
Member

She works as expected! Though, crash reports aren't really useful for tracing back given there's no debug files uploaded, it can at leas indicate that something's wrong with a PR build. I'm sure we can also set up a GHA label to upload debug files if needed too.

@digisomni digisomni merged commit 0d9076c into master Dec 15, 2020
@digisomni digisomni deleted the feature/gha-sentry branch December 15, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HifiExperiments HifiExperiments HifiExperiments left review comments

@ctrlaltdavid ctrlaltdavid ctrlaltdavid approved these changes

Assignees
No one assigned
Labels
CR Approved At least one code reviewer has approved the PR. enhancement New feature or request QA Approved The PR has been tested successfully. rebuild rebuild through the GithubActions
Projects
None yet
Milestone
2020.3.3 Release
Development

Successfully merging this pull request may close these issues.

Add Sentry crash reporting to GHA
5 participants
@two-one-five @vircadia-build-notifier @digisomni @ctrlaltdavid @HifiExperiments