Create App. - Feature Bundle - Dec 2020 #894

AleziaKurdis · 2020-12-01T05:43:39Z

Content of this feature bundle:

New "Tools" menu to the Create Application

The previous "Selection" and "Actions" menu has been renamed "Select" and "Edit".
We have now all the actions regrouped in the 3 menus: "Select", "Edit" and "Tools".

Some changes coming with this:
1- The menu "Teleport To Selected Entities" has been moved from the "Select" menu to the new "Tools" menu.

2- The "Hotkey" "G" is now used to toggle the grid (previously it was to align it to the selection). It was making sense to have G (for Grid) to manage the visibility of this one.

3- New "Hotkey" has been added to control the other actions related to the Grid:
"Activate/Deactivate Snap to Grid" can be triggered by clicking "H"
"Align Grid to Selected Entities" can be triggered by clicking "J"
"Align Grid to Avatar" can be triggered by clicking "K"

4- The actions: "Align Grid to Selected Entities" and "Align Grid to Avatar" will turn on the grid if it was not visible. (Doing this imply that you want to have the grid to be visible). But you will still need to do "Toggle Grid" (G) to turn the grid off.
Note that "Align Grid to Selected Entities" will happen only If there is at least one entity selected.

Main "Edit" menu

The 2 "Import Entities" actions have been brought back to the main "Edit" menu.
(Since there was no unanimity about their removal)

A separator has been added to regroup the Create App's menuItems.

Upgrade to current master

Create App "tools" menu implementation

Add Grid Actions Shortkeys Toggle Grid G Activate/Deactivate Snap to Grid H Align Grid to Selected Entities J Align Grid to Avatar K

AleziaKurdis · 2020-12-01T05:47:48Z

This commit is fully functional, This means that it can be tested.
But "Do Not Merge" now.
I might add additional features in the next week.
or do readjustments depending some feedbacks?

scripts/system/create/edit.js

scripts/system/create/entityList/html/js/entityList.js

scripts/system/libraries/gridTool.js

vircadia-build-notifier · 2020-12-01T07:20:33Z

The following links are available:
build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR894/Vircadia-Alpha-PR894-31dd724_bbde93f5.dmg

build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR894/Vircadia-Alpha-PR894-31dd724_bbde93f5.exe

build (ubuntu-18.04, android)

1- Replace Overlays by Local Entities 2- Add the missing header with copyright and license (I have assumed that the author was the same person that make the grid parameter that is referenced there and only used in create App.) 3- Minor requested code change (0.0 instead of 0 in condition using real numbers)

AleziaKurdis · 2020-12-02T04:00:27Z

Grid upgrade...
The Grid is now using a "local" Entity instead of a deprecated 3d Overlay.

Minor code changes

Minor code change

vircadia-build-notifier · 2020-12-02T06:27:36Z

The following links are available:
build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR894/Vircadia-Alpha-PR894-740f7dd_670d832c.dmg

build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR894/Vircadia-Alpha-PR894-740f7dd_670d832c.exe

build (ubuntu-18.04, android)

AleziaKurdis · 2020-12-03T04:02:44Z

You can remove the "Do Not Merge" tag.
That will be all for this PR.
I expected to address the Grid issues with the Local mode, but the expected behavior is far to be clear.

Aitolda · 2020-12-04T01:33:19Z

Everything seems to be working as intended.

SilverfishVR · 2020-12-04T20:55:10Z

PR894-740f7dd

Looks good 👍 👍 only issue I found is that the default width of the create window (in desktop) is too narrow to fit the new buttons:

Actually it is also too narrow for the Properties page to show properly so maybe the best solution is to just make the default wider?

AleziaKurdis · 2020-12-05T01:09:03Z

Is this the tablet mode in Desktop?
( I would have expected this to do as in VR .. and be displayed in landscape)

Previously it was 490px wide (in Desktop) Now it will be 750 px wide (in Desktop) The properties tab is now with an acceptable size by default. (which is closer to the landscape display we have in HMD.) No change in HMD or in-Tablet display.

In Desktop mode, the 2 import buttons are now one over the other and full width. The text was overlapping with the default Create Tools window size.

AleziaKurdis · 2020-12-05T04:55:32Z

Create Tools window width (in Desktop mode)...
In desktop mode only, the default windows width is now 750px instead of 490px.
which is closer than what we have in HMD (which is landscape display)
the 2 Import buttons (only in HMD) are now one under the other, in full width.
No change in HMD.

Please test and let me know if this is fine.

vircadia-build-notifier · 2020-12-05T06:42:02Z

The following links are available:
build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR894/Vircadia-Alpha-PR894-2020ccc_536bf4ef.dmg

build (ubuntu-18.04, full)

build (ubuntu-18.04, android)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/kasenvr_project-athena/PR894/Vircadia-Alpha-PR894-2020ccc_536bf4ef.exe

SilverfishVR · 2020-12-05T18:28:53Z

looks good to me, mind you, that's on a UWQHD monitor but as long as it fits in a full HD monitor (so you can resize it) I thinks it's good

AleziaKurdis added 11 commits November 28, 2020 15:11

Merge pull request #2 from kasenvr/master

76b7ca9

Upgrade to current master

Create App "tools" menu implementation

af9367a

Create App "tools" menu implementation

Create App "tools" menu implementation

ab999e5

Create App "tools" menu implementation

Create App "tools" menu implementation

21eee3c

Create App "tools" menu implementation

Create App "tools" menu implementation

7d364ad

Create App "tools" menu implementation

Create App "tools" menu implementation

889b74d

Create App "tools" menu implementation

Create App "tools" menu implementation

64caa54

Create App "tools" menu implementation

Add Grid Actions Shortkeys

1f20536

Add Grid Actions Shortkeys Toggle Grid G Activate/Deactivate Snap to Grid H Align Grid to Selected Entities J Align Grid to Avatar K

Add Grid Actions Shortkeys

6a31c19

Add Grid Actions Shortkeys Toggle Grid G Activate/Deactivate Snap to Grid H Align Grid to Selected Entities J Align Grid to Avatar K

Add Grid Actions Shortkeys

71d0fb5

Add Grid Actions Shortkeys Toggle Grid G Activate/Deactivate Snap to Grid H Align Grid to Selected Entities J Align Grid to Avatar K

Add Grid Actions Shortkeys

bbde93f

Add Grid Actions Shortkeys Toggle Grid G Activate/Deactivate Snap to Grid H Align Grid to Selected Entities J Align Grid to Avatar K

AleziaKurdis mentioned this pull request Dec 1, 2020

Docs: Create 'Create' app help guide with hotkeys and functionality details then link to that from the 'Create' app #880

Open

ctrlaltdavid added do not merge do not merge due to issues or pending updates needs CR (code review) needs testing (QA) The PR is ready for testing labels Dec 1, 2020

ctrlaltdavid requested changes Dec 1, 2020

View reviewed changes

AleziaKurdis added 2 commits December 1, 2020 23:04

Minor code changes

5a71881

Minor code changes

Minor code change

670d832

Minor code change

AleziaKurdis requested a review from ctrlaltdavid December 2, 2020 04:33

ctrlaltdavid approved these changes Dec 2, 2020

View reviewed changes

ctrlaltdavid added CR Approved At least one code reviewer has approved the PR. and removed do not merge do not merge due to issues or pending updates needs CR (code review) labels Dec 3, 2020

two-one-five added this to the 2020.3.3 Release milestone Dec 3, 2020

two-one-five added the enhancement New feature or request label Dec 3, 2020

AleziaKurdis added 2 commits December 4, 2020 23:47

2 large import button in Desktop

536bf4e

In Desktop mode, the 2 import buttons are now one over the other and full width. The text was overlapping with the default Create Tools window size.

two-one-five requested a review from ctrlaltdavid December 5, 2020 19:12

ctrlaltdavid added needs CR (code review) and removed CR Approved At least one code reviewer has approved the PR. labels Dec 5, 2020

ctrlaltdavid approved these changes Dec 5, 2020

View reviewed changes

ctrlaltdavid added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Dec 5, 2020

digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Dec 10, 2020

digisomni merged commit 3c44d11 into vircadia:master Dec 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Create App. - Feature Bundle - Dec 2020 #894

Create App. - Feature Bundle - Dec 2020 #894

Uh oh!

AleziaKurdis commented Dec 1, 2020

Uh oh!

AleziaKurdis commented Dec 1, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vircadia-build-notifier commented Dec 1, 2020

Uh oh!

AleziaKurdis commented Dec 2, 2020

Uh oh!

vircadia-build-notifier commented Dec 2, 2020

Uh oh!

AleziaKurdis commented Dec 3, 2020

Uh oh!

Aitolda commented Dec 4, 2020

Uh oh!

SilverfishVR commented Dec 4, 2020

Uh oh!

AleziaKurdis commented Dec 5, 2020

Uh oh!

AleziaKurdis commented Dec 5, 2020 •

edited

Loading

Uh oh!

vircadia-build-notifier commented Dec 5, 2020

Uh oh!

SilverfishVR commented Dec 5, 2020

Uh oh!

Uh oh!

Create App. - Feature Bundle - Dec 2020 #894

Create App. - Feature Bundle - Dec 2020 #894

Uh oh!

Conversation

AleziaKurdis commented Dec 1, 2020

Uh oh!

AleziaKurdis commented Dec 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vircadia-build-notifier commented Dec 1, 2020

Uh oh!

AleziaKurdis commented Dec 2, 2020

Uh oh!

vircadia-build-notifier commented Dec 2, 2020

Uh oh!

AleziaKurdis commented Dec 3, 2020

Uh oh!

Aitolda commented Dec 4, 2020

Uh oh!

SilverfishVR commented Dec 4, 2020

Uh oh!

AleziaKurdis commented Dec 5, 2020

Uh oh!

AleziaKurdis commented Dec 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vircadia-build-notifier commented Dec 5, 2020

Uh oh!

SilverfishVR commented Dec 5, 2020

Uh oh!

Uh oh!

AleziaKurdis commented Dec 1, 2020 •

edited

Loading

AleziaKurdis commented Dec 5, 2020 •

edited

Loading