Skip to content

Update GitHub links#908

Merged
digisomni merged 4 commits intovircadia:masterfrom
ctrlaltdavid:fix/update-links
Dec 17, 2020
Merged

Update GitHub links#908
digisomni merged 4 commits intovircadia:masterfrom
ctrlaltdavid:fix/update-links

Conversation

@ctrlaltdavid
Copy link
Collaborator

A successful PR build will test many of these lnks.
Other links should be checked in a code review.

@ctrlaltdavid ctrlaltdavid added housekeeping Code or documentation cleanup needs testing (QA) The PR is ready for testing needs CR (code review) labels Dec 12, 2020
@digisomni digisomni added this to the 2020.3.3 Release milestone Dec 12, 2020
Copy link
Contributor

@JulianGro JulianGro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how the files in cmake/ports/ work so I cannot approve those, but I haven't found any issues.

@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Dec 14, 2020
Copy link
Member

@digisomni digisomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything is building (on GHA) correctly. :)

@ctrlaltdavid ctrlaltdavid added the rebuild rebuild through the GithubActions label Dec 17, 2020
@digisomni digisomni removed the needs testing (QA) The PR is ready for testing label Dec 17, 2020
@digisomni digisomni merged commit 2d22f9a into vircadia:master Dec 17, 2020
@ctrlaltdavid ctrlaltdavid deleted the fix/update-links branch December 17, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CR Approved At least one code reviewer has approved the PR. housekeeping Code or documentation cleanup rebuild rebuild through the GithubActions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants