Skip to content

Update GitHub links #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 17, 2020
Merged

Update GitHub links #908

merged 4 commits into from
Dec 17, 2020

Conversation

ctrlaltdavid
Copy link
Collaborator

A successful PR build will test many of these lnks.
Other links should be checked in a code review.

@ctrlaltdavid ctrlaltdavid added housekeeping Code or documentation cleanup needs testing (QA) The PR is ready for testing needs CR (code review) labels Dec 12, 2020
HifiExperiments
HifiExperiments reviewed Dec 12, 2020
View reviewed changes
@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

build (windows-latest, full)

@digisomni digisomni added this to the 2020.3.3 Release milestone Dec 12, 2020
@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

build (ubuntu-18.04, android)

build (windows-latest, full)

JulianGro
JulianGro approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@JulianGro JulianGro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how the files in cmake/ports/ work so I cannot approve those, but I haven't found any issues.

@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Dec 14, 2020
digisomni
digisomni approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@digisomni digisomni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything is building (on GHA) correctly. :)

@ctrlaltdavid ctrlaltdavid added the rebuild rebuild through the GithubActions label Dec 17, 2020
@digisomni digisomni removed the needs testing (QA) The PR is ready for testing label Dec 17, 2020
@digisomni digisomni merged commit 2d22f9a into vircadia:master Dec 17, 2020
@JulianGro JulianGro mentioned this pull request Dec 17, 2020
Closed
@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

build (ubuntu-18.04, android)

build (windows-latest, full)

@ctrlaltdavid ctrlaltdavid deleted the fix/update-links branch December 17, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianGro JulianGro JulianGro approved these changes

@HifiExperiments HifiExperiments HifiExperiments approved these changes

@digisomni digisomni digisomni approved these changes

Assignees
No one assigned
Labels
CR Approved At least one code reviewer has approved the PR. housekeeping Code or documentation cleanup rebuild rebuild through the GithubActions
Projects
None yet
Milestone
2020.3.3 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@ctrlaltdavid @vircadia-build-notifier @JulianGro @HifiExperiments @digisomni