Skip to content

Add Tips for making pull request to CONTRIBUTING.md #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 17, 2020
Merged

Add Tips for making pull request to CONTRIBUTING.md #916

merged 4 commits into from
Dec 17, 2020

Conversation

vegaslon
Copy link
Contributor

Add a few pointer to make it easier to get a PR through for the next guy.

JulianGro
JulianGro suggested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@JulianGro JulianGro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot give suggestions for line 10, 51 and 52 via GitHub for some reason, but one might as well go the extra mile to get those up to date.

JulianGro
JulianGro approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@JulianGro JulianGro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually all those outdated links are changed in PR #908 , so this is fine if it gets rebased after #908 gets merged

digisomni
digisomni requested changes Dec 14, 2020
View reviewed changes
@digisomni
Copy link
Member

There are other open references PRs that will update references such as links to the repo.

digisomni
digisomni requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@digisomni digisomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one last thing but otherwise looks good. :)

@digisomni digisomni merged commit 1b26220 into vircadia:master Dec 17, 2020
@digisomni digisomni added the docs Improvements or additions to documentation label Dec 17, 2020
@digisomni digisomni added this to the 2020.3.3 Release milestone Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianGro JulianGro JulianGro approved these changes

@daleglass daleglass daleglass approved these changes

@digisomni digisomni digisomni approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
2020.3.3 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@vegaslon @digisomni @JulianGro @daleglass