Fix crashes when running with QML disabled in VR#971
Merged
HifiExperiments merged 8 commits intovircadia:masterfrom Feb 2, 2021
Merged
Fix crashes when running with QML disabled in VR#971HifiExperiments merged 8 commits intovircadia:masterfrom
HifiExperiments merged 8 commits intovircadia:masterfrom
Conversation
HifiExperiments
added
VR
HifiExperiments
commented
Jan 18, 2021
| void OffscreenUi::hideDesktopWindows() { | ||
| if (QThread::currentThread() != thread()) { | ||
| BLOCKING_INVOKE_METHOD(this, "hideDesktopWindows"); | ||
| if (_desktop) { |
Contributor
Author
There was a problem hiding this comment.
both crashes happens because when QML is disabled, we don't initialize _desktop
HifiExperiments
commented
Jan 18, 2021
|
The following links are available:
build (macOS-latest, full) build (windows-latest, full) |
Contributor
|
The crash still happens to me: |
HifiExperiments
added
rebuild
Contributor
|
It gets further now (I see the world loading and maybe even finish loading in the SteamVR preview window) but still crashes: |
|
The following links are available:
build (macOS-latest, full) build (ubuntu-18.04, android) |
Contributor
|
Next crash: |
HifiExperiments
force-pushed
the
apitraceFix
branch
from
bb8c8c8 to
ff6f723
Compare
|
The following links are available:
build (macOS-latest, full) build (ubuntu-18.04, android) |
Contributor
|
Green light from me. but that should be fixed by #937 |
Collaborator
|
Rebuilding now that Qt downloads required for Windows build are working again ... |
ctrlaltdavid
added
rebuild
|
The following links are available: build (ubuntu-18.04, full)
build (windows-latest, full) build (ubuntu-18.04, android) |
Collaborator
|
How do you build with QML disabled? |
Contributor
Author
|
I would say it’s uncommon. it’s necessary to do GPU traces via tools like apitrace or nsight, per the related radars. given that it’s uncommon and that most of this PR just boils down to nullptr checks, I would say this is a low risk change, even though it touches a few files one way to disable it is by changing set(DISABLE_QML_OPTION OFF) to ON in CMakeLists.txt |
ctrlaltdavid
requested changes
Jan 29, 2021
Co-authored-by: David Rowe <david@ctrlaltstudio.com>
Co-authored-by: David Rowe <david@ctrlaltstudio.com>
Co-authored-by: David Rowe <david@ctrlaltstudio.com>
|
The following links are available:
build (macOS-latest, full) build (windows-latest, full) build (ubuntu-18.04, android) |
ctrlaltdavid
approved these changes
Feb 1, 2021
ctrlaltdavid
added
CR Approved
digisomni
approved these changes
Feb 2, 2021
Member
digisomni
left a comment
digisomni
left a comment
There was a problem hiding this comment.
I don't know what a DISABLE_QML build is supposed to fully look like but it didn't crash in desktop or VR on Windows.
digisomni
added
QA Approved
Contributor
It won't have any UI elements like the toolbar, apps, settings, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #810
fixes #811
Test plan: