Skip to content

Remove requirement of admin / logged in to teleport to people nearby #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2021
Merged

Remove requirement of admin / logged in to teleport to people nearby #991

merged 1 commit into from
Jan 31, 2021
+1 −1

Conversation

digisomni
Copy link
Member

No description provided.

@digisomni digisomni added the enhancement New feature or request label Jan 31, 2021
@digisomni digisomni added this to the 2021.1.0 Release milestone Jan 31, 2021
@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

build (windows-latest, full)

build (ubuntu-18.04, android)

@ctrlaltdavid ctrlaltdavid self-requested a review January 31, 2021 04:23
ctrlaltdavid
ctrlaltdavid approved these changes Jan 31, 2021
View reviewed changes
Copy link
Collaborator

@ctrlaltdavid ctrlaltdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently,. you can only see a user's username if you're a domain admin or you "know" them, hence the test on the individual namecards prevented the teleport.

@ctrlaltdavid ctrlaltdavid added CR Approved At least one code reviewer has approved the PR. needs testing (QA) The PR is ready for testing labels Jan 31, 2021
@Aitolda
Copy link
Collaborator

Aitolda commented Jan 31, 2021

Seems to work as far as teleport goes.

@digisomni digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Jan 31, 2021
@digisomni digisomni merged commit e539a38 into vircadia:master Jan 31, 2021
@JulianGro JulianGro mentioned this pull request Feb 11, 2021
Open
@digisomni digisomni deleted the feature/allow-pal-teleport branch February 11, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlaltdavid ctrlaltdavid ctrlaltdavid approved these changes

Assignees
No one assigned
Labels
CR Approved At least one code reviewer has approved the PR. enhancement New feature or request QA Approved The PR has been tested successfully.
Projects
None yet
Milestone
2021.1.0 Eos Release
Development

Successfully merging this pull request may close these issues.
4 participants
@digisomni @vircadia-build-notifier @Aitolda @ctrlaltdavid