Vmsa ovmf #10
Merged
Vmsa ovmf #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream kernel introduced[^1] a new IOCTL called KVM_SEV_INIT2 which expects some floating point registers to be set to a value other than zero. Because of these adjustments, we needed to update the VMSA structure to match this. [^1]: [https://lore.kernel.org/kvm/[email protected]/](https://lore.kernel.org/kvm/[email protected]/) With KVM_SEV_INIT2, rather than 0, QEMU/KVM will instead begin setting the following fields in the VMSA before measurement/encryption: VMSA byte offset [1032:1033] = 80 1f (MXCSR, Multimedia Control Status Register) VMSA byte offset [1040:1041] = 7f 03 (FCW, FPU/x86 Control Word) Setting FCW (FPU/x86 Control Word) to 0x37f is consistent with 11.5.7 of APM Volume 2. MXCSR reset state is not defined for XSAVE, but QEMU's 0x1f80 value is consistent with machine reset state documented in APM Volume 2 4.2.2. As such, it is reasonable to begin including these in the VMSA measurement calculations. Based on the following fix: virtee/sev-snp-measure@ae95e59 Signed-off-by: Jagannathan Raman <[email protected]>
New OVMF changes added section SVSM_CAA to OvmfSevMetadata. To calculate the measurement with this new section, the new section has to be added and needs to be treated as zero pages when encountered. Based on the this commit: virtee/sev-snp-measure@cc93bb0 Signed-off-by: Jagannathan Raman <[email protected]>
Signed-off-by: Jagannathan Raman <[email protected]>
|
@derpsteb Hi Otto, could you please take a look at this PR? Thank you so much! |
|
@derpsteb Did you get a chance to take a look at this? I'm unable to add you as a reviewer to this PR. Thank you! |
|
@DGonzalezVillal Thanks for approving the PR! Appreciate it. Could you please merge it? I don't have the permissions to do it. Thank you! |
|
@DGonzalezVillal Could you please merge this? |
|
My apologies I forgot to merge that one time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.