Skip to content

[RHEL-22354] Preparation PR for NBL chain series #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 12, 2025

Conversation

ybendito
Copy link
Collaborator

This PR is a collection of minor changes and instrumentations taken out from development branch related to support for NBL chains completion for easier review

ybendito added 10 commits April 10, 2025 12:33
When the device has one queue we do not need to analyze the
hash and send NBLs one by one.

Signed-off-by: Yuri Benditovich <[email protected]>
This feature is disabled in production, we just fix the
compilation problems when it is enabled.

Signed-off-by: Yuri Benditovich <[email protected]>
Move the last TX completion timestamp from per-adapter
context to per-queue context for better visibility.

Signed-off-by: Yuri Benditovich <[email protected]>
Note that this is unsafe method and the result can be
used only for information / tracking, not for decisions.

Signed-off-by: Yuri Benditovich <[email protected]>
Signed-off-by: Yuri Benditovich <[email protected]>
If one NB failed, the entire NBL is not send, so we need
to reflect this in TX errors. Also adding printout in such
a case.

Signed-off-by: Yuri Benditovich <[email protected]>
If defined (by default disabled by compilation) we keep the
NBL history in the CNBL as a list of events. Especially
useful for stuck NBL that has not completed. From the
dump we'll be able to read the history.

Signed-off-by: Yuri Benditovich <[email protected]>
@ybendito ybendito requested a review from YanVugenfirer as a code owner April 10, 2025 10:35
@ybendito
Copy link
Collaborator Author

ybendito commented Apr 11, 2025

Win10: BSOD on RSS test assertion "pCurrentNetBufferList", no surprise
2025 and 2022 - strict property validation failed @kostyanf14
Upd: 2025 passed on retry
Upd: 2022 passed after update
All the rest is ok
@YanVugenfirer Please review and merge, the next series is based on it

@kostyanf14
Copy link
Member

@ybendito 2025 - strict property validation failed unexpectedly, this env was updated. There is no log in the HLKX package for some reason.
2022 - will update

@YanVugenfirer
Copy link
Collaborator

@ybendito 2025 - strict property validation failed unexpectedly, this env was updated. There is no log in the HLKX package for some reason. 2022 - will update

@kostyanf14 sorry, please clarify - is there still a failure of NicStrict test after update?

@kostyanf14
Copy link
Member

@ybendito 2025 - strict property validation failed unexpectedly, this env was updated. There is no log in the HLKX package for some reason. 2022 - will update

@kostyanf14 sorry, please clarify - is there still a failure of NicStrict test after update?

Yes, for some reason wtl log was missing, so HLK marked test as failed. Rerun pass

@YanVugenfirer YanVugenfirer merged commit b7b94a0 into virtio-win:master Apr 12, 2025
6 of 9 checks passed
@YanVugenfirer
Copy link
Collaborator

@ybendito merged

@ybendito ybendito deleted the chains_preparation branch May 16, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants