netkvm: added event logging for critical failures in ParaNdis6_Initialize to improve diagnostics

[zjmletang]

for the problem description
please visit #1343

Signed-off-by: Zhang JianMing [email protected]

[YanVugenfirer]

Can one of the admins verify this patch?

[zjmletang]

@YanVugenfirer Please hold on, this PR is temporarily for discussion only. I will add my thoughts in the issue shortly.

[YanVugenfirer]

@YanVugenfirer Please hold on, this PR is temporarily for discussion only. I will add my thoughts in the issue shortly.

"Can one of the admins verify this patch?” - this is Jenkins generated message :)

[zjmletang]

@YanVugenfirer Please hold on, this PR is temporarily for discussion only. I will add my thoughts in the issue shortly.

"Can one of the admins verify this patch?” - this is Jenkins generated message :)

Haha, I see! I was wondering how you replied so quickly. (^_^)

[YanVugenfirer]

Looks like a good start.

[YanVugenfirer]

@zjmletang Do you want to add something else to PR?

[zjmletang]

@zjmletang Do you want to add something else to PR?
@YanVugenfirer Nothing more for now. I adjusted the Clang formatting style and resubmitted it.

[ybendito]

@zjmletang I'd prefer something shorter (in the code this takes many lines and makes the code less readable).
Just as an example: in the ndis56common something like:

#define NDIS_ERR(handle, code1, code2, ...) \
    `NdisWriteErrorLogEntry(handle, NDIS_ERROR_CODE_##code1, code2, __LINE__, __VA_ARGS__)`

And in the code just:
NDIS_ERR(miniportAdapterHandle, UNSUPPORTED_CONFIGURATION, 2, status);

[ybendito]

@zjmletang Also, I think we do not need to enter number of params manually. For simplicity we can:
a) always use 2 params, at the moment should be enough
b) automatically recognize number of parameters and use it in a call (more complicated, I agree)

[zjmletang]

@zjmletang Also, I think we do not need to enter number of params manually. For simplicity we can: a) always use 2 params, at the moment should be enough b) automatically recognize number of parameters and use it in a call (more complicated, I agree)

@ybendito Thank you very much. I have updated a new version based on your guidance

[ybendito]

rerun tests

[ybendito]

Tests: Win11 - LSO test "failed" (problem of HCK, no real failure at all), pass on rerun
All the rest passed.
I think we can merge it. @YanVugenfirer