fix: Handle response error when nil #720
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces deprecated runtime.WithCaptureResponse with policy.WithCaptureResponse and adds guards against nil response errors to prevent panics.
- Swap
runtime.WithCaptureResponseforpolicy.WithCaptureResponsein two packages - In
GetACISubnet, guardrespErr.RawResponseagainst nil before checking status - Update error checks in client APIs to use
errors.As(though some checks are misapplied)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/network/aci_network.go | Replaced capture helper and added nil guard on respErr.RawResponse |
| pkg/client/client_apis.go | Replaced capture helper and modified 404 checks using errors.As |
helayoty
force-pushed
the
helayoty/fix-resp-err
branch
from
e9c4e2c to
766dd9a
Compare
Signed-off-by: Heba Elayoty <[email protected]>
…sCode Co-authored-by: Copilot <[email protected]> Signed-off-by: Heba <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Heba <[email protected]>
helayoty
force-pushed
the
helayoty/fix-resp-err
branch
from
766dd9a to
0eea5d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
GetACISubnetfunction, the response error is not handled byerrors.As(err, &respErr), which will cause nil pointer dereference when the response error is nil.runtime.WithCaptureResponseis deprecated in favor ofpolicy.WithCaptureResponse