Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable renaming in product and configuration editors #179

Conversation

franzTobiasDLR
Copy link
Member

@franzTobiasDLR franzTobiasDLR commented Aug 14, 2023

Closes #168
Closes #173

Add rename command and menu contributeions to both new navigator views... So F2 is now working again.

Also the actions

  • undo
  • update
  • commit / push
  • refresh
  • copy
  • paste
    are now working in the customized navigator views

I created custom menus for both editors so that the product navigator only allows adding product elements and the configration editor only configration elements....

Furthermore, I implemented a new index-based sorter that sorts the SEIs in boths views. In core it somehow works without this ^^

The main changes can be found in the Plugin.XML:
de.dlr.sc.virsat.model.extension.cefx.ui/plugin.xml

@franzTobiasDLR franzTobiasDLR added the comfort/usasbility Usability improvement label Aug 14, 2023
@franzTobiasDLR franzTobiasDLR added this to the Release 4.16.0 milestone Aug 14, 2023
@franzTobiasDLR franzTobiasDLR self-assigned this Aug 14, 2023
@franzTobiasDLR franzTobiasDLR changed the title Enable renaming in product and configuration editors WIP: Enable renaming in product and configuration editors Aug 14, 2023
franzTobiasDLR and others added 3 commits August 15, 2023 09:12
…ts-in-the-product-navigator-and-configuration-navigator-with-the-f2-key-in-cef-x
…navigator-and-configuration-navigator-with-the-f2-key-in-cef-x' of https://github.com/virtualsatellite/VirtualSatellite4-CEF.git into feature/168-allowing-to-rename-elements-in-the-product-navigator-and-configuration-navigator-with-the-f2-key-in-cef-x
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #179 (53d48ec) into development (d8ddf53) will not change coverage.
Report is 1 commits behind head on development.
The diff coverage is n/a.

❗ Current head 53d48ec differs from pull request most recent head 75af456. Consider uploading reports for the commit 75af456 to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #179   +/-   ##
==============================================
  Coverage          87.85%   87.85%           
  Complexity           511      511           
==============================================
  Files                 73       73           
  Lines               1729     1729           
  Branches             209      209           
==============================================
  Hits                1519     1519           
  Misses               139      139           
  Partials              71       71           

@franzTobiasDLR franzTobiasDLR changed the title WIP: Enable renaming in product and configuration editors Enable renaming in product and configuration editors Aug 15, 2023
@dellerDLR
Copy link
Contributor

dellerDLR commented Aug 17, 2023

I think the Generate/Configure Product Wizard is missing in the Product Navigator and Configuration Navigator.

image

image

@franzTobiasDLR
Copy link
Member Author

I think the ConfigurationTree Wizard is missing in the Product Navigator. Same with the AssemblyTree Wizard in the Configuration Navigator

True, but no one is using them in the CEF. ^^ And with them you would, again, create a new tree, which you don't see in the selected viewer. That's what I wanted to fix with these custom menus.

@dellerDLR dellerDLR merged commit 119b3c7 into development Aug 17, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comfort/usasbility Usability improvement
Projects
None yet
3 participants