Cleanup of unused and naming improvements of existing paramters #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellerDLR
force-pushed
the
feature/169-cleanup-unused-params
branch
from
3c64bbe
to
f631376
Compare
Codecov Report
@@ Coverage Diff @@
## development #180 +/- ##
=================================================
- Coverage 87.85% 87.75% -0.10%
- Complexity 511 512 +1
=================================================
Files 73 74 +1
Lines 1729 1732 +3
Branches 209 209
=================================================
+ Hits 1519 1520 +1
- Misses 139 141 +2
Partials 71 71
|
dellerDLR
force-pushed
the
feature/169-cleanup-unused-params
branch
from
f631376
to
4aae9d6
Compare
pchrszon-dlr
approved these changes
Aug 16, 2023
| } | ||
|
|
||
| Category EquipmentPowerParameters { | ||
| Applicable For [de.dlr.sc.virsat.model.extension.ps.ElementDefinition, de.dlr.sc.virsat.model.extension.ps.ElementConfiguration, de.dlr.sc.virsat.model.extension.ps.ElementOccurence, de.dlr.sc.virsat.model.extension.ps.ElementRealization]; | ||
| Cardinality 1; | ||
|
|
||
| Type powerUnitActive of Category Parameter quantityKind "Dimensionless" unit "No Unit" description "Should be 1 if the equipment is active in the given mode, 0 in case it is totally off."; | ||
| Type powerUnitIsInactive of Category Parameter quantityKind "Dimensionless" unit "No Unit" description "Should be 1 if the equipment is active in the given mode, 0 in case it is totally off."; |
There was a problem hiding this comment.
Is the description still correct? I think it should say the opposite if the parameter is negated, right?
There was a problem hiding this comment.
Right, the description has to be updated
I also checked the |
franzTobiasDLR
approved these changes
Aug 16, 2023
| } | ||
|
|
||
| Category EquipmentPowerParameters { | ||
| Applicable For [de.dlr.sc.virsat.model.extension.ps.ElementDefinition, de.dlr.sc.virsat.model.extension.ps.ElementConfiguration, de.dlr.sc.virsat.model.extension.ps.ElementOccurence, de.dlr.sc.virsat.model.extension.ps.ElementRealization]; | ||
| Cardinality 1; | ||
|
|
||
| Type powerUnitActive of Category Parameter quantityKind "Dimensionless" unit "No Unit" description "Should be 1 if the equipment is active in the given mode, 0 in case it is totally off."; | ||
| Type powerUnitIsInactive of Category Parameter quantityKind "Dimensionless" unit "No Unit" description "Should be 1 if the equipment is active in the given mode, 0 in case it is totally off."; |
There was a problem hiding this comment.
The description is still "Active" ^^ Pls update: I will add a suggestion that you can directly apply
| } | ||
|
|
||
| Category EquipmentPowerParameters { | ||
| Applicable For [de.dlr.sc.virsat.model.extension.ps.ElementDefinition, de.dlr.sc.virsat.model.extension.ps.ElementConfiguration, de.dlr.sc.virsat.model.extension.ps.ElementOccurence, de.dlr.sc.virsat.model.extension.ps.ElementRealization]; | ||
| Cardinality 1; | ||
|
|
||
| Type powerUnitActive of Category Parameter quantityKind "Dimensionless" unit "No Unit" description "Should be 1 if the equipment is active in the given mode, 0 in case it is totally off."; | ||
| Type powerUnitIsInactive of Category Parameter quantityKind "Dimensionless" unit "No Unit" description "Should be 1 if the equipment is active in the given mode, 0 in case it is totally off."; |
There was a problem hiding this comment.
Suggested change
| Type powerUnitIsInactive of Category Parameter quantityKind "Dimensionless" unit "No Unit" description "Should be 1 if the equipment is active in the given mode, 0 in case it is totally off."; | |
| Type powerUnitIsInactive of Category Parameter quantityKind "Dimensionless" unit "No Unit" description "Should be 1 if the equipment is inactive in the given mode, meaning it is totally off."; | |
There was a problem hiding this comment.
Didn't see that, I like your version more :D
dellerDLR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft for the cleanup of the mass and power parameters.
AFAIK it is not possible to set a default value for a parameter.
As a result the
PowerUnitIsActivecannot be assigned a default value of1Fixes #169