Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testcases with special shapes to Im- and Exporter #20

Closed
2 tasks done
ghost opened this issue Dec 18, 2019 · 1 comment
Closed
2 tasks done

Add testcases with special shapes to Im- and Exporter #20

ghost opened this issue Dec 18, 2019 · 1 comment
Labels
feature New feature or request

Comments

@ghost
Copy link

ghost commented Dec 18, 2019

Add testcases for shape:

  • geometry
  • none
@ghost ghost changed the title Add testcases with special shapes to Im Add testcases with special shapes to Im- and exporter Dec 18, 2019
@ghost ghost changed the title Add testcases with special shapes to Im- and exporter Add testcases with special shapes to Im- and Exporter Dec 18, 2019
@ghost ghost mentioned this issue Dec 18, 2019
2 tasks
ghost pushed a commit that referenced this issue Jan 6, 2020
Tests not running successful at the moment.

---
Task #20: Add testcases with special shapes to Im- and Exporter
ghost pushed a commit that referenced this issue Jan 6, 2020
---
Task #20: Add testcases with special shapes to Im- and Exporter
ghost pushed a commit that referenced this issue Jan 6, 2020
Add _export_to_stl function
Update test_full_export_shape_geometry test case

---
Task #20: Add testcases with special shapes to Im- and Exporter
ghost pushed a commit that referenced this issue Jan 13, 2020
- None shape now creates a dummy part instead of not having a part file
- Update shape handling in JsonPartFactory (now get's shape from the
sheet)
- Add test cases
- Cleanup None and Geometry files

---
Task #20: Add testcases with special shapes to Im- and Exporter
@ghost
Copy link
Author

ghost commented Jan 13, 2020

Updated handling of Geometry and None shape, both should work sufficient for now.

Opened #22 for further improvements on the None shape handlings usability.

ghost pushed a commit that referenced this issue Jan 13, 2020
---
Task #20: Add testcases with special shapes to Im- and Exporter
@ghost ghost closed this as completed Feb 3, 2020
@ghost ghost added this to the Relese_0.1.0_Beta milestone Feb 5, 2020
@ghost ghost added the feature New feature or request label Feb 5, 2020
@ghost ghost mentioned this issue Apr 1, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

0 participants