Feature/task 20 add testcases with spe #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 6, 2020 13:08
Tests not running successful at the moment. --- Task #20: Add testcases with special shapes to Im- and Exporter
--- Task #20: Add testcases with special shapes to Im- and Exporter
Add _export_to_stl function Update test_full_export_shape_geometry test case --- Task #20: Add testcases with special shapes to Im- and Exporter
- None shape now creates a dummy part instead of not having a part file - Update shape handling in JsonPartFactory (now get's shape from the sheet) - Add test cases - Cleanup None and Geometry files --- Task #20: Add testcases with special shapes to Im- and Exporter
--- Task #20: Add testcases with special shapes to Im- and Exporter
ghost
added
the
ghost
requested a review
from 
PhilMFischer
approved these changes
Jan 29, 2020
|
Closes #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test cases for None and Geometry shapes in Im- and Exporter:
sheet)