Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #9371 - Set default map style if not provided #9419

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bijanvakili
Copy link
Contributor

@bijanvakili bijanvakili commented Feb 10, 2025

Tested with Google Maps in this notebook

Closes #9371

Change List

  • Added get_default_map_identifier to map_styles.py to determine map identifier key based on map provider
  • Extended Deck constructor to choose a default map style for all 3 providers (as DARK is not an appropriate default for Google Maps)
    • Using a "sentinel" value as default to still allow disabling style (using None) if no base map is used.
  • Added unit test to test_deck.py to verify default map style for major map providers if none is provided

@coveralls
Copy link

Coverage Status

coverage: 91.635%. remained the same
when pulling 119da90 on bijanvakili:issue-9371
into 2819e97 on visgl:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [pydeck] Incorrect default map style for Google basemap
2 participants