feat: Add show_error flag to display error in cell output#9430
Merged
felixpalmer merged 5 commits intovisgl:masterfrom Feb 17, 2025
Merged
feat: Add show_error flag to display error in cell output#9430felixpalmer merged 5 commits intovisgl:masterfrom
felixpalmer merged 5 commits intovisgl:masterfrom
Conversation
felixpalmer
approved these changes
Feb 14, 2025
felixpalmer
pushed a commit
that referenced
this pull request
Feb 17, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9370
This is a smaller-scoped fix to propagate Javascript errors so that they are immediately visible in a python notebook.
The intent is to make it easier to iterate on errors or collect information for bugs.
Background
This is a short term fix for issue #9370 until the refactor suggested in #9064 is completed.
Change List
onErrorhandler to determine whether to show adeck.glerror in the HTML output or via the browser consolecreateDeckexception handler catch block to call the newonErrorhandler.show_errorboolean flag to instructpydeck.Deckto display the error immediately instead of logging it to the developer consoleNOTE: This does not raise a python exception from
Deck.to_html(). The method still considers its execution as succeeded.When
show_errorisTrue, the resulting output should look similar to the following screenshot: