Skip to content

Demonstrate integration between TheatreJS and Deck.gl #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chrisgervang
Copy link
Collaborator

POC of an AnimatedLayer, which wraps a Deck Layer with animatable properties using TheatreJS. Each uniform and accessor on a layer can be animated independently, and are grouped together for each layer into theatre.js "Sheet Objects"

  • Extract props from Deck Layers to create equivalent TheatreJS props
  • Props defined in the application and considered "controlled" and will not be modified by theatre.
  • Sub-layer props are not extracted

A similar concept could be done for deck.gl Views, Effects, Extensions, and other components.

While not implemented, animations could be swapped by changing the "sheet" prop, a TheatreJS sheet.
This solution doesn't explore animating individual data elements within a layer.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12958787782

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.533%

Totals Coverage Status
Change from base Build 12093894547: 0.0%
Covered Lines: 1557
Relevant Lines: 2851

💛 - Coveralls

@charlieforward9
Copy link
Contributor

This looks very exciting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants