Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallax effect on background video #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hasa93
Copy link

@hasa93 hasa93 commented Oct 17, 2017

Font color might need to be lighter once this feature has been augmented

@vishalsanghai
Copy link
Owner

Hey @hasa93. Thanks for your work.
But I think you misunderstood the issue, we only want the background video fixed in the first screen. But your solution makes the background of the whole page as the fixed video.

@hasa93
Copy link
Author

hasa93 commented Oct 17, 2017

Oops my bad will get back on it

@vishalsanghai
Copy link
Owner

Good work, but I think it's not perfect.
When we scroll down, till a point the video remains full screen but we want the container of the video to also get smaller as we scroll so when the next section comes it's not abrupt.
See this for reference : https://codepen.io/markhillard/pen/ogbmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants