Prevent reset the node color to the group color from storePositions function #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomaash
added
the
can't reproduce
|
Hi @veredwpsemantix, could you provide an MWE of the issue please? From what you posted this seems like a pretty serious issue in vis-data and should therefore be fixed there. What you provided is more of a hack around it (assuming I understand the problem correctly, which is difficult to gauge without an MWE). Thanks and sorry for the atrocious response time PS: There are JSFiddle and CodePen buttons on https://visjs.github.io/vis-network/examples/ to make MWE creation easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the reset of node color when we call to storePositions function.
Example:
before storePositions:
after storePositions:
