-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement fetch transport (POC) #18485
Draft
hi-ogawa
wants to merge
48
commits into
vitejs:main
Choose a base branch
from
hi-ogawa:feat-fetch-transport
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,507
−724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d check the value
Co-authored-by: Vladimir <[email protected]>
hi-ogawa
force-pushed
the
feat-fetch-transport
branch
from
October 28, 2024 02:31
7b2fab3
to
01bc234
Compare
hi-ogawa
force-pushed
the
feat-fetch-transport
branch
from
October 28, 2024 06:38
01bc234
to
83d3004
Compare
hi-ogawa
force-pushed
the
feat-fetch-transport
branch
from
November 1, 2024 01:38
83d3004
to
01cf7e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
base branch: #18362
diff: sapphi-red:refactor/single-transport...hi-ogawa:feat-fetch-transport
On top of #18362 and with a same spirit as #18338, this PR adds a primitives for server and client transports with builtin server middleware. I had initial implementation in hi-ogawa/vite-environment-examples#140 and mostly copied it here. Currently the diff is only the last commit of this PR.
Example (see fetch-transport.spec.ts)
TBD
http://localhost:5010
, need wait for server listen, etc...),/@vite/transport
request which can expose arbitraryfetchModule