perf(client): reduce reload debounce #20429
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p2-nice-to-have
bluwy
reviewed
Jul 23, 2025
There was a problem hiding this comment.
Perhaps we can test how this affects reloads in practice before merging? Generally I think the reload itself and network requests after is going to take some time too that a 40ms reduction will probably be unnoticable. A slower machine might also process things slower when doing git switch and stuff.
If we're directly reducing and test it out by users, I'm a bit more comfortable with 20ms first.
|
20ms works for me. I feel a small lag with 50ms, but 20ms feels instant. |
sapphi-red
commented
Jul 24, 2025
bluwy
approved these changes
Jul 25, 2025
patak-dev
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This debounce makes all reload requests to be deferred at least 50ms, which is a bit long.
Given that this was introduced for #13512, I guess 10ms is enough. #13512 isn't clear what happened there, and if it is caused by
git switch, I think the multiple reload requests would be sent within 10ms.refs #13545