Skip to content

refactor: use environment transform request #20430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 20, 2025
Merged

refactor: use environment transform request #20430

merged 5 commits into from
Jul 20, 2025

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 19, 2025 •
edited
Loading

Description

Made transformRequest to be not called from functions other than environment.transformRequest.

  • 477921b: made server.warmupRequest to use environment.warmupRequest to remove duplicate code
  • 49efc34: removed options.ssr handling in transformRequest as it was not used
  • cc0895d: split TransformOptionsInternal type as ssr option is only used for server.transformRequest and server.warmupRequest
  • 9d34bac: made the transform middleware to use environment.transformRequest instead of transformRequest so that transformRequest is only used from environment.transformRequest

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Jul 19, 2025
@sapphi-red sapphi-red mentioned this pull request Jul 19, 2025
Merged
@sapphi-red sapphi-red merged commit 24e6a0c into vitejs:main Jul 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hi-ogawa hi-ogawa hi-ogawa approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @hi-ogawa