Feature: multi language #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @vividvilla
Thank you for this great theme! But, I think, it is more convenient that the theme can deal with multi language page. Therefore, I modified following:
Modify hyperlink of title
When click the site title, we can go to the home of present language.
Add hyperlink to its translations
When the present article has translations, the link to them will appear on the same line with the menu.
All changes work well on my web site, it contains Japanese and English pages (now, it has only home and about page...). I have just started to use Hugo, and not being familiar with HTML/CSS. If this PR is silly, please discard.
Thanks,