VIVO-4069 - Add javascript MIME type to ipretResults responses #4070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue: #4069
What does this pull request do?
Sets the MIME type for a couple specific responses from the Ajax Visualization Controller which are formatted as javascript instead of plaintext or JSON.
What's new?
Functionality should remain the same, but you should be able to confirm the MIME type is set correctly by looking at the response in your developer console in the browser.
How should this be tested?
Observe the Content-Type when making a call to http://localhost:8080/vivo/visualizationAjax?vis=capabilitymap&query=Virology&callback=ipretFullResults (You will need to replace the query with a valid concept in your VIVO database)
The Content-Type before the change will be "text/html"
The Content-Type after the change will be "text/javascript"
Note that application/javascript is also a valid MIME type for javascript, but apparently text/javascript has broader compatibility.
Additional Notes:
Interested parties
@VIVO-project/vivo-committers
Reviewers' expertise
Please add any new expertise in the list which might be needed for reviewing your PR or remove any of the listed if it is not needed.
Candidates for reviewing this PR should have some of the following expertises: