-
Notifications
You must be signed in to change notification settings - Fork 85
Infrastructure improvements - Migration to Java 11 from Java 8 #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
9234b50
50d0595
3a43423
59fa166
def3890
7896a33
9fc52e7
1c7dde2
8ebc531
85d558e
46a5149
ef11d69
271978b
1c2564d
42f31dd
27725b0
dbd162e
3d5b754
56d2f83
c0e5c8d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package compilation; | ||
|
||
import static org.junit.Assert.*; | ||
|
||
import org.junit.Test; | ||
|
||
public class IsNotCompatibleWithJava8 { | ||
/* | ||
* This code segment is compatible with Java 11 and not compatible with java 8. It will abort the compilation if the Java context is version 8 | ||
*/ | ||
@Test | ||
public void test() { | ||
String value = "This code is compiled in Java 11"; | ||
System.out.println(value.isBlank()); | ||
} | ||
Comment on lines
+11
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't understand this. Maybe this might be useful - https://stackoverflow.com/questions/14572287/testing-different-java-versions-in-junit#answer-14573109 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @chenejac There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we need a test for that. I would suggest to remove it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The question is in which scenario someone can run tests using JDK 8, when we are requesting 11 in pom.xml file. It is of course possible, but completely out of VIVO installation/building procedure, should we take care in that case? Anyway, if some test is needed, it shouldn't just print some message, we need assertion (probably in this case assertFalse(value.isBlank()), but not sure what will happen in JDK 1.8 case). |
||
|
||
} |
Uh oh!
There was an error while loading. Please reload this page.