Skip to content

Search range slider fix and improvement #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

litvinovg
Copy link
Member

  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What does this pull request do?

Fixes missing label for selected date range.
Adds input fields for date range slider.

How should this be tested?

  • Put configuration for date range filter into rdf/display/firsttime and remove .txt suffix from file name
  • Load sample data
  • Select a range, try manually modifying start and end values.
  • Verify that there is a button to remove selected filter on search page.

Interested parties

@VIVO-project/vivo-committers

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. HTML, CSS, JavaScript
  2. FreeMarker

Reviewers' report template

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg it looks ok for me, and it works for me in accordance with the expectations. I have followed testing instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants