Improvement product ar #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix test_address_ru
Added brazilian phone_number
Added extra vehicle data
…odes Exclude invalid area codes
Change repo url
Adds Swiss cantons and phone number
Changes to danish names and cities
Stricter test for ffaker#223
This commits generates data for - Indian states - Union territories - Pincodes - Time zone The FFaker::AddressIN class contains the methods to generate Indian Addresses
Better regex to the test class
Indian addresses
Tests for DA
Most users will only want a few modules from ffaker, but we always import all of them. This is a little bit slow and eats some memory This changes ffaker's modules to load only as they are needed, using only the memory and startup time that is needed.
Ruby 1.9 was broken by 3b279e0 Ruby 1.9 reached EOL February 23, 2015, so I don't think it is worth supporting.
- Add test for PhoneNumberFR - Add international numbers on PhoneNumberFR - Clean code based on PhoneNumberBR structure
fixes `Uncaught exception: invalid byte sequence in US-ASCII` when using RubyMine's debugger
Add a generator to create EAN13 codes.
* Improve FFaker::Time.between docs and implementation The FFaker::Time.between method worked only for parameters of the Time class. Now it works with Date, DateTime, ActiveSupport::TimeWithZone or String objects. * removes redundant returns * Use single quotes in TestFakerTime test * Fix FFaker::Time.between docs markup
* Added base setup for LoremIrish (FFaker::LoremIE) * Added documentation for lorem irish * Updated formatting based on houndci results * Moving # frozen_string_literal: true above encoding since houndci is expecting it * Updated test & module logic to follow main Lorem pattern of returning an array of items * Updated reference link to include name * Updated quote style to single quotes * Updated quote style to single quotes * Updated irish datasets and tests * Words list now only has single words, not phrases
…me` methods (ffaker#360) `FFaker::Time.between` returns instance of `Time`, so `.date` should returns instance of `Date` (without time), and `.datetime` should returns instance of `DateTime` (with time). Users can convert it to String as they want.
* Added a `FFaker::LoremPL` module with Polish Lorem. * Updated the reference with documentation of the `FFaker::LoremPL` module.
* Month can not be zero * Day can not be zero * Not every month has 31 days
* Create FFaker::Image module * Test FFaker::Image module * Document FFaker::Image module * Code cleanup
* Add tests for FFaker::SSN.ssn to ./test/test_ssn.rb * Implement FFaker::SSN.ssn according to the SSN validity rules * Fix the regex pattern in the test_ssn_format test in ./test/test_ssn.rb * DRY-up the tests in ./test/test_ssn.rb * Strip leading zeros in ssn_to_number_groups helper method in test/test_ssn.rb * Add parens around params lists of Kernel#assert in test/test_ssn.rb * Use deterministic #fetch_sample instead of a direct call to Array#sample * Address style guideline violations in ./lib/ffaker/ssn.rb and ./test/test_ssn.rb * Replace Integer#positive? with an explicit comparison against 0 in ./test/test_ssn.rb * Simplify the test ssn_first_group_in_valid_range with regex * merge test ssn_first_group_in_valid_range into test ssn_format * Splat ranges passed as a param to #fetch_sample in the #ssn method * Replace (x > 0) with the more explicit (x != 0) in ./test/test_ssn.rb * Split a map-chain by introducing a temp var * Remove redundant test helpers in test_ssn.rb, merge separate group tests into test ssn_groups_non_zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
62 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement of BRANDS, ADJ & NOUN arrays. Now they references to argentinian appliance market.