Add set canvas element #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simzer
reviewed
May 28, 2024
CHANGELOG.md
Outdated
| @@ -7,6 +7,10 @@ | |||
| - Do not calculate disabled markers to the color normalization. | |||
| - More precise TS type for transform matrix in event handlers. | |||
|
|
|||
| ### Added | |||
|
|
|||
| - The canvas cahange options to the htmlcanvas plugin. | |||
| @@ -20,6 +20,7 @@ export interface HtmlCanvasApi extends PluginApi { | |||
| get element(): HTMLCanvasElement | |||
| /** Returns the actual canvas context */ | |||
| get context(): CanvasRenderingContext2D | |||
| set element(element: HTMLCanvasElement) | |||
There was a problem hiding this comment.
Please add comment (needed for generated reference documentation)
Also better place would be right after get element().
| @@ -128,6 +140,11 @@ export class HtmlCanvas implements Plugin, HtmlCanvasAlternative { | |||
| return this._mainCanvas | |||
| } | |||
|
|
|||
| set element(element: HTMLCanvasElement) { | |||
| this.unregister() | |||
There was a problem hiding this comment.
We shouldn't call unregister here, since it also unregisters the window resize event listener, which we need further on.
| @@ -44,6 +45,7 @@ export class HtmlCanvas implements Plugin, HtmlCanvasAlternative { | |||
| return { | |||
| element: this.element, | |||
| context: this.context, | |||
| setElement: this._setElement.bind(this), | |||
There was a problem hiding this comment.
It would be better to have getter setter for element here:
return {
get element() { ... }
set element() { ... }
}
Also calling _setElement() here is faulty, since it does not register the handlers to the canvas, just stores the element to the class.
| window.addEventListener('resize', this._resizeHandler) | ||
| } | ||
|
|
||
| private _setElement(element: HTMLCanvasElement): void { |
There was a problem hiding this comment.
This method is not necessary, we should cann _setCanvas() for the API object.
simzer
previously approved these changes
May 30, 2024
simzer
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.