Fix clang-tidy(-18) issues #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schaumb
commented
Jul 31, 2024
•
schaumb
commented
- parent class function hides same member function
- Replace CHAR_BITS and M_PI to C++ replacements
- Remove void function returns
- move rvalue references/perfect forward universal references
- move type_traits to C++17 '_v' suffixes
- include all includes to C++
- Remove nested '?:' ternary operators
- Remove implicit inlines
- Make all enum base to uint8_t
- Remove some unnecessary namespace prefix
- Change enable_if to requires
- std::ignore some argument and return values
- header guard to canvas.h
- Replace CHAR_BITS and M_PI to C++ replacements - Remove void function returns - move rvalue references / prefect forward universal references - move type_traits to C++17 '_v' suffixes - include all includes to c++ - Remove nested ? : ternary operators - Remove implicit inlines - Make all enum base to uint8_t - Remove some unnecessary namespace prefix - Change enable_if to requires - std::ignore some argument - header guard to canvas.h
schaumb
force-pushed
the
clang-tidy-fixes
branch
from
b14c970
to
29f2618
Compare
schaumb
force-pushed
the
clang-tidy-fixes
branch
from
29f2618
to
4e6948c
Compare
# Conflicts: # src/base/geom/circle.cpp # src/base/geom/circle.h # src/base/geom/rect.cpp # src/base/geom/triangle.cpp
simzer
previously approved these changes
Aug 12, 2024
| : srcOpt->geometry == Gen::ShapeType::line ? in3 | ||
| : trgOpt->geometry == Gen::ShapeType::line ? out3 | ||
| : inOut5; | ||
| const ::Anim::Easing *geomEasing{&inOut5}; |
There was a problem hiding this comment.
The calng-tidy says that there are identical if-branches.
simzer
previously approved these changes
Aug 12, 2024
simzer
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.