Add Mobile Menu Button #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prep for making them more complex
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| focusMain(): void { | ||
| const mainHeading = document.getElementById('main-content'); | ||
|
|
||
| mainHeading!.focus(); |
Check warning
Code scanning / ESLint
Disallow non-null assertions using the `!` postfix operator Warning
|
A boring UI change that passes CI, so going to admin merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a button to open and close the header menu on mobile, and tweaks some mobile spacing to make it more compact and useful, like he search page in particular. Here's a diff:
Fixes #7
Testing Instructions
Confirmed the mobile menu opens and closes properly and is easy to use with a keyboard.
Checklist: