Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Unreported Records For Python Grade Calculation #132

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

AlexanderTyan
Copy link
Collaborator

@AlexanderTyan AlexanderTyan commented Oct 23, 2024

Description

Change/rerun data preprocessing to keep unreporting records.

Relates to issue #129, because we need non-reporting data in the CSV to calculate reporting grades

Testing Instructions

Please describe the tests/QA that you did to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit a5cd8c9
🔍 Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/6734164a7c1701000893a9e4
😎 Deploy Preview https://deploy-preview-132--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vkoves vkoves changed the title Keep unreported records Keep Unreported Records For Python Grade Calculation Oct 23, 2024
@vkoves
Copy link
Owner

vkoves commented Oct 23, 2024

@AlexanderTyan - it looks like you'll need to update the Python tests scripts, because now there's more records in the historical data than it expected!

@vkoves vkoves self-assigned this Oct 23, 2024
@vkoves vkoves added enhancement New feature or request data Data updates & tweaks labels Oct 23, 2024
@AlexanderTyan
Copy link
Collaborator Author

AlexanderTyan commented Oct 29, 2024

@vkoves i updated the test output csv according to the newly changed processing + updated expected answers in tests to match what's in there. the updated test_output.csv now has 'Not Submitted' rows, as well as 'Submitted Data' and 'Submitted' rows.

[edit: grammar]

@AlexanderTyan
Copy link
Collaborator Author

This is the old test_output.csv for the record:
test_output_backup.csv

@vkoves
Copy link
Owner

vkoves commented Oct 30, 2024

@AlexanderTyan - So I did find one issue, it looks like this change breaks the historical graphs, I think because now they are getting empty data 😭

Prod Deploy Preview
Screenshot from 2024-10-29 21-27-26 Screenshot from 2024-10-29 21-27-13

I think this can be fixed by making each graph filter out empty data - do you feel comfortable giving that a try, would you like me to try and fix it, or would you like to pair up on it next Chi Hack Night?

@AlexanderTyan
Copy link
Collaborator Author

@vkoves yeah, let's pair up next ChiHackNight!

Copy link
Owner

@vkoves vkoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, awesome work!

@vkoves vkoves merged commit 6b38990 into main Nov 13, 2024
7 checks passed
@vkoves vkoves deleted the keep_unreported_records branch November 13, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Data updates & tweaks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants