Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hard Coded 2020 Years By Moving to Constant #64

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

SuragNuthulapaty
Copy link
Collaborator

@SuragNuthulapaty SuragNuthulapaty commented Jan 10, 2024

Description

Moved latest data year to a global variable to be referenced instead of hard coding the data year

Fixes #62

Before After
Screenshot from 2024-01-09 22-26-22 Screenshot from 2024-01-09 22-26-27

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit 3a256e6
🔍 Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/659e1da5d4af610008bdd44f
😎 Deploy Preview https://deploy-preview-64--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/components/DataDisclaimer.vue Fixed Show fixed Hide fixed
src/components/DataDisclaimer.vue Fixed Show fixed Hide fixed
src/components/DataDisclaimer.vue Fixed Show fixed Hide fixed
src/components/DataDisclaimer.vue Fixed Show fixed Hide fixed
src/constants/globals.vue Fixed Show fixed Hide fixed
src/components/DataDisclaimer.vue Fixed Show fixed Hide fixed
src/components/DataDisclaimer.vue Fixed Show fixed Hide fixed
src/pages/About.vue Fixed Show fixed Hide fixed
src/pages/BiggestBuildings.vue Fixed Show fixed Hide fixed
@SuragNuthulapaty SuragNuthulapaty changed the title add globals Change hard coded data year to a global constant Jan 10, 2024
@SuragNuthulapaty SuragNuthulapaty marked this pull request as ready for review January 10, 2024 04:06
@vkoves vkoves changed the title Change hard coded data year to a global constant Fix Hard Coded 2020 Years By Moving to Constant Jan 10, 2024
@vkoves vkoves self-assigned this Jan 10, 2024
@vkoves vkoves added the bug Something isn't working label Jan 10, 2024
Copy link
Owner

@vkoves vkoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I made some minor doc updates to make clear to folks they need to update that variable if they update the data

@vkoves vkoves merged commit 6063578 into main Jan 10, 2024
6 checks passed
@vkoves vkoves deleted the change-data-year branch January 10, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Data Disclaimer Saying Data is from 2020
2 participants