Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Blog Page with Post About Missed Fines #76

Merged
merged 13 commits into from
Mar 1, 2024
Merged

Create Blog Page with Post About Missed Fines #76

merged 13 commits into from
Mar 1, 2024

Conversation

vkoves
Copy link
Owner

@vkoves vkoves commented Feb 21, 2024

Description

Adds a new blog page with a new article about how the city missed out in $30 million in fines by not enforcing the energy benchmarking ordinance.

Blog Page Post Top
Screenshot from 2024-02-27 23-57-05 Screenshot from 2024-02-27 23-57-26

Resolves #75

Testing Instructions

Viewed the new blog page and post on desktop and mobile and ran AxeDevTools to confirm it has no accessibility issues.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit d11c307
🔍 Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/65e153efe79bf4000732d3cf
😎 Deploy Preview https://deploy-preview-76--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/pages/Blog.vue Fixed Show fixed Hide fixed
src/pages/blog/MillionsInMissedFines.vue Fixed Show fixed Hide fixed
src/pages/blog/MillionsInMissedFines.vue Fixed Show fixed Hide fixed
@vkoves vkoves changed the title Start blog page about missed fines Create Blog Page with Post About Missed Fines Feb 28, 2024
@vkoves vkoves added the enhancement New feature or request label Feb 28, 2024
@vkoves vkoves marked this pull request as ready for review February 28, 2024 05:59

// TODO: Figure out a way to get metaInfo working without any
// https://github.com/xerebede/gridsome-starter-typescript/issues/37
@Component<any>({

Check warning

Code scanning / ESLint

Disallow the `any` type Warning

Unexpected any. Specify a different type.
src/pages/blog/MillionsInMissedFines.vue Fixed Show fixed Hide fixed
@vkoves
Copy link
Owner Author

vkoves commented Feb 28, 2024

Suggestion in Slack from Soren:

Parachuting in to nitpick that I think in several places where you use the word "buildings" alone to describe the party that is required to report, it may be better to use "building owners". It's like the "car" vs. "driver" distinction in traffic crash reporting.


// TODO: Figure out a way to get metaInfo working without any
// https://github.com/xerebede/gridsome-starter-typescript/issues/37
@Component<any>({

Check warning

Code scanning / ESLint

Disallow the `any` type Warning

Unexpected any. Specify a different type.
>

<p class="caption">
The full data portal screenshot, and a zoomed in view of the query result count (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line seems to be not rendering properly

Screenshot 2024-02-28 at 4 30 14 PM

@derekeder
Copy link
Collaborator

this is great - hopefully it will turn a few heads. do you plan to pitch to a publication? block club, trib or sun-times might be interested.

a few notes:

  • might be worth updating the home page to feature this blog post if you want more people to find/read it
  • shorter version of the headline reads a little better: "City Of Chicago Failed to Collect $30 Million In Potential Fines from Building Benchmarking Ordinance"
  • add a way to contact you for follow-up information

@vkoves
Copy link
Owner Author

vkoves commented Feb 28, 2024

@derekeder - great suggestions, I've added my external contact email to the post and added a new panel to the homepage:

Screenshot from 2024-02-28 17-00-07

Thoughts?

@derekeder
Copy link
Collaborator

nice. i think the two alerts are competing with each other with color a bit. might look better if they were stacked vertically instead of horizontal too.

@vkoves
Copy link
Owner Author

vkoves commented Feb 28, 2024

@derekeder - I did that before, but then you have to scroll down more on desktop view the actual table. I could make the legislative update background white, perhaps?

@derekeder
Copy link
Collaborator

yah white background would help i think

src/pages/Index.vue Fixed Show fixed Hide fixed
src/pages/Index.vue Fixed Show fixed Hide fixed
@vkoves
Copy link
Owner Author

vkoves commented Mar 1, 2024

Merging this in since folks have looked at it and it's not changing data

@vkoves vkoves merged commit 7221cd9 into main Mar 1, 2024
6 checks passed
@vkoves vkoves deleted the add-blog-page branch March 1, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate Potential Fines Based on Number of Non-Submitting Buildings
2 participants