Update the README #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sradco
force-pushed
the
update_readme
branch
2 times, most recently
from
10a397c
to
e59546c
Compare
vladikr
reviewed
Mar 20, 2024
| $ git clone https://github.com/vladikr/logsviewer | ||
| $ cd logsviewer/ | ||
| $ make build -C tools/lvctl/ | ||
| $ mv tools/lvctl/bin/lvctl /usr/local/bin/ |
vladikr
reviewed
Mar 20, 2024
README.md
Outdated
| @@ -1,13 +1,12 @@ | |||
| # Troubleshooting as a serivce | |||
| # Troubleshooting as a service using Must-Gather | |||
There was a problem hiding this comment.
Do you see a benefit in only committing to Must-Gathers?
I mean, right now we don't have any other reliable way, but in the general case, we could make it work with cluster dump or even connecting to a live cluster. I think plain Kubernetes doesn't operate on Must-Gathers.
There was a problem hiding this comment.
@vladikr I updated based on your comment. Please review.
Signed-off-by: Shirly Radco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the README with latest updates.