Add link on image in ItemsCard and FeedItem #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Lidiya-prog
commented
Nov 2, 2021
Lidiya-prog
commented
|
|
vladimirshefer
requested changes
Nov 4, 2021
src/components/ImageButton.vue
Outdated
| }) | ||
| export default class ImageButton extends Vue { | ||
| @Prop() | ||
| name!: string |
src/components/ImageButton.vue
Outdated
| @Component<ImageButton>({ | ||
| name: "ImageButton" | ||
| }) | ||
| export default class ImageButton extends Vue { |
There was a problem hiding this comment.
Название компонента выглядит как будто это кнопка, на которой есть картинка.
vladimirshefer
requested changes
Nov 9, 2021
| @@ -64,14 +65,15 @@ | |||
| <script lang="ts"> | |||
| import TagBadge from "@/components/TagBadge.vue"; | |||
| import ItemCardOpenButton from "@/components/UserWishlist/ItemCardOpenButton.vue"; | |||
| import OpenImageButton from "@/components/OpenImageButton.vue"; | |||
There was a problem hiding this comment.
Изменения в этом файле кажутся ненужными. Тут только импорт и упоминание компонента,, но реально он нигде не юзается
| @@ -139,6 +148,7 @@ export default { | |||
| isMoneyCollectingEnabled: false, | |||
| link: "", | |||
| donatelink: "", | |||
| imagelink: "", | |||
There was a problem hiding this comment.
Пожалуйста, пользуйся camelCase для именования. imagelink -> imageLink
src/components/OpenImageButton.vue
Outdated
| @@ -0,0 +1,34 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Этот компонент где то используется? Если нет - удали
|
|
| @@ -71,7 +71,7 @@ import ProgressBar from "@/components/ProgressBar.vue"; | |||
|
|
|||
| @Component<ItemCard>({ | |||
| name: "ItemCard", | |||
| components: {ProgressBar, TagBadge, ItemCardOpenButton} | |||
| components: { ProgressBar, TagBadge, ItemCardOpenButton } | |||
There was a problem hiding this comment.
В этом файле ничего не изменилось по сути. Откати плз форматирование
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.