Skip to content

Conversation

@fynnsu
Copy link
Collaborator

@fynnsu fynnsu commented Nov 17, 2025

SUMMARY:
#1981 added Qwen3VLMoe with associated tests, however this model isn't available on all transformers versions that we support. Therefore, (similar to #2030) this pr ensures we don't import or test the model when using a transformers version that doesn't support it.

TEST PLAN:
Confirmed that this change fixes import llmcompressor when using oldest support transformers version 4.54.0. Ran test with old transformers version (test gets skipped) and new transformers version (test passes).

@github-actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fynnsu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues with the Qwen3VLMoe model across different versions of the transformers library. It ensures that the llmcompressor library can gracefully handle environments where this specific model is not available, preventing import errors and allowing relevant tests to be skipped appropriately. This change improves the robustness and backward compatibility of the system by adapting to varying transformers library capabilities.

Highlights

  • Conditional Import Handling: Implemented conditional imports for Qwen3VLMoe related classes within src/llmcompressor/modeling/qwen3_vl_moe.py by utilizing TYPE_CHECKING to prevent runtime import errors on older transformers versions.
  • Test Skipping for Compatibility: Added a pytest.mark.skipif decorator to test_calib_qwen3_vl_moe_module in tests/llmcompressor/modeling/test_calib_qwen3_vl_moe.py. This ensures the test is skipped if the Qwen3VLMoe model is not available in the installed transformers version, maintaining compatibility.
  • Type Hint Refinement: Updated type hints in src/llmcompressor/modeling/qwen3_vl_moe.py to directly reference Qwen3VLMoeTextSparseMoeBlock after moving the transformers imports into a TYPE_CHECKING block, simplifying the code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to provide compatibility with older versions of the transformers library by making the import of Qwen3VLMoe components conditional. The changes in the test file are well-implemented, using a try-except block to gracefully handle missing dependencies and skip tests. However, the corresponding change in the source file src/llmcompressor/modeling/qwen3_vl_moe.py is less robust. I've provided a suggestion to improve its reliability by adopting a similar try-except pattern, which will prevent potential runtime errors.

Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu fynnsu added the ready When a PR is ready for review label Nov 17, 2025
@fynnsu fynnsu added the qwen For any PR / issue related to Qwen support label Nov 17, 2025
@kylesayrs kylesayrs enabled auto-merge (squash) November 17, 2025 21:56
@kylesayrs kylesayrs merged commit 6e459ed into main Nov 17, 2025
9 checks passed
@kylesayrs kylesayrs deleted the fix_qwen3vlmoe branch November 17, 2025 22:15
dsikka pushed a commit that referenced this pull request Nov 18, 2025
SUMMARY:
The goal of this pr is to speed up time to signal on new prs. 

Currently, we have the following CI tests:
- `base-tests`: total runtime `4m26s`, install deps `3m43s`, run test
`30s`
- `pytorch-tests`: total runtime `3m27s`, install deps `3m4s`, run test
`12s`
- `quality-check`: total runtime `3m3s`, install deps `2m58s`, run test
`0s`

*times based on runs from this pr
#2040. Note exact
times will fluctuate substantially.

After this pr, we have:
- `base-tests`: total runtime `1m14s`, install deps `16s`, run test
`41s`
- `pytorch-tests`: total runtime `55s`, install deps `14s`, run test
`22s`
- `quality-check`: total runtime `19s`, install deps `10s`, run test
`0s`

*times based on runs from this pr
fynnsu#1 on my fork.


TEST PLAN:
Tested by running CI.

Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen For any PR / issue related to Qwen support ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants